Modularize Javascript Files

[sulcata]

Modularize the files in app/assets/javascript. It'd probably be best to incorporate Browserify or something.

[sulcata]

I still stand by this even without linting. Concatenating files is messy and we have certain Pokemon database files being included multiple times.

[coyotte508]

using something like browserify, as long as it's automated and easily usable, does sound like a good idea. Not sure why the issue is closed.

[sulcata]

I closed the eslint issue, not this one. Unless someone else closed this one. There are other options like Webpack or RequireJS we could use, I'll try looking into which will work better.

[coyotte508]

@sulcata now that the client can be run locally, with electron, browserify sounds an even better idea

[sulcata]

If we're sticking with CommonJS imports we should go with browserify. If we decide to switch to using ES6 imports we might want to consider webpack v2 (not stable yet) since it has some fancy tree shaking features to remove unused code that uglify can't remove.

edit: just realized we're not actually using CommonJS outside of node since we're concating lol

[coyotte508]

The thing is, currently, I could use require() if I want and the javascript in the electron app would work fine, but the web one would need browserify.

If, by using import, it would still work fine inside the electron app without any change or processing, then why not! I'm all for using recent settings.

[sulcata]

It should work just fine in the electron app provided we bundle the scripts. I'm not sure whether or not we want to bundle all the scripts. If we don't bundle the scripts for electron then we'd need to translate the imports to CommonJS during the build with babel since node/V8 doesn't support es6 imports yet (which isn't hard to set up).

If we're going the webpack route we might want to even consider ditching grunt since all our grunt tasks can be done with just webpack it seems.

[coyotte508]

https://medium.com/@housecor/browserify-vs-webpack-b3d7ca08a0a9#.xl97th5df

Let's go with webpack?

[coyotte508]

I'm going to get started on it. And reindent everything to 2 spaces because there'll be a lot of major changes.

[sulcata]

Well, in the time it took me to make my last post it looks like Webpack 2 finally released (after at least a year i think lol). Imo we should be going with the import/export syntax in the webclient files since it can be better optimized.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import

I've been working with Webpack 2 quite a bit over the past day for my calc so I'll see what I can add.

[sulcata]

I'll start working on switching to import/export unless you have any objections.

[coyotte508]

Go ahead! Keep in mind that what I've done is only partial and a lot of things are broken for now in the webpack branch.

[sulcata]

Yeah, I thought the bundle size looked a little small xd

It might be a good idea to reorganize certain things. Class definitions are sort of split over multiple files right now.