Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
## Contributing Guidance - v3
## Contributing Guidance - v4

* Target your pull requests to the **version-3** branch
* Target your pull requests to the **version-4** branch
* Add/Update any docs articles related to your changes
* Include a test for any new functionality and ensure all existing tests are passing by running `npm test`
* If you are fixing a bug, include a test that would have caught the bug you are fixing
* Ensure tslint checks pass by typing `npm run lint`
* Ensure lint checks pass by typing `npm run lint`
* Keep your PRs as simple as possible and describe the changes to help the reviewer understand your work
* If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :)
* If you have an idea for a larger change to the library please [open an issue](https://github.com/pnp/pnpjs/issues) and let's discuss before you invest many hours - these are very welcome but want to ensure it is something we can merge before you spend the time :)
2 changes: 1 addition & 1 deletion docs/concepts/nightly-builds.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Nightly Builds

Starting with version 3 we support nightly builds, which are built from the version-3 branch each evening and include all the changes merged ahead of a particular build. These are a great way to try out new features before a release, or get a fix or enhancement without waiting for the monthly builds.
Starting with version 3 we support nightly builds, which are built from the current development branch (currently `version-4`) each evening and include all the changes merged ahead of a particular build. These are a great way to try out new features before a release, or get a fix or enhancement without waiting for the monthly builds.

You can install the nightly builds using the below examples. While we only show examples for `sp` and `graph` nightly builds are available for all packages.

Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Pull requests may be large or small - adding whole new features or fixing some misspellings. Regardless, they are all appreciated and help improve the library for everyone! By following the below guidelines we'll have an easier time merging your work and getting it into the next release.

* Target your pull requests to the **version-3** branch
* Target your pull requests to the **version-4** branch
* Add/Update any relevant docs articles in the relevant package's docs folder related to your changes
* Include a test for any new functionality and ensure all existing tests are passing by running `npm test`
* Ensure linting checks pass by typing `npm run lint`
Expand Down