Skip to content

Fixes "by" translation and fuzzy dates for document_byline.pt #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
szakitibi wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fixes "by" translation and fuzzy dates for document_byline.pt #369

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
19b63f0
Fix translation "by" in document_byline.pt
szakitibi May 27, 2024
1b7a2bf
Use from-now format and local time tooltip for modified in document_b…
szakitibi May 27, 2024
bc47002
add change log
szakitibi May 27, 2024
4006451
fix typo
szakitibi May 27, 2024
73bda96
Merge branch 'master' into fix_by_translation_and_dates
jensens Jun 17, 2024
c1cb938
Update news/369.bugix
szakitibi Jun 17, 2024
d6b8463
revert dates back to absolute one
szakitibi Jun 17, 2024
8722cff
Update 369.bugix
szakitibi Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/369.bugix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fixes the "by" translation and the date issues for document byline viewlet
Comment thread
szakitibi marked this conversation as resolved.
Outdated
[szakitibi]
48 changes: 29 additions & 19 deletions plone/app/layout/viewlets/document_byline.pt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,23 @@
tal:condition="python:creator_ids and view.show_about()"
>
<span class="label-by-author">
<tal:i18n i18n:translate="">by</tal:i18n>
<tal:for repeat="user_id creator_ids">
<tal:user define="
url_path python: view.get_url_path(user_id);
fullname python:view.get_fullname(user_id);
">
<a class="badge rounded-pill bg-light text-dark fw-normal fs-6"
href="${navigation_root_url}/${url_path}"
tal:condition="url_path"
>${fullname}</a>
<span class="badge rounded-pill bg-light text-dark fw-normal fs-6"
tal:condition="not:url_path"
>${fullname}</span>
</tal:user>
</tal:for>
<tal:i18n i18n:translate="label_by_author">
by
<tal:for repeat="user_id creator_ids" i18n:name="author">
<tal:user define="
url_path python: view.get_url_path(user_id);
fullname python:view.get_fullname(user_id);
">
<a class="badge rounded-pill bg-light text-dark fw-normal fs-6"
href="${navigation_root_url}/${url_path}"
tal:condition="url_path"
>${fullname}</a>
<span class="badge rounded-pill bg-light text-dark fw-normal fs-6"
tal:condition="not:url_path"
>${fullname}</span>
</tal:user>
</tal:for>
</tal:i18n>
&mdash;
</span>
</tal:creators>
Expand All @@ -37,7 +39,12 @@
tal:condition="published"
>
<span i18n:translate="box_published">published</span>
<span tal:content="python:context.toLocalizedTime(published)">Published</span>
<span tal:content="published"
class="pat-display-time"
data-pat-display-time="from-now: true"
datetime="${published}"
title="${python: context.toLocalizedTime(published, long_format=True)}"
>Published</span>
<tal:sep condition="show_modification_date">,</tal:sep>
</span>

Expand All @@ -47,9 +54,12 @@
<span i18n:translate="box_last_modified">
last modified
</span>
<span tal:content="python:context.toLocalizedTime(modified)">
Modified
</span>
<span tal:content="modified"
class="pat-display-time"
data-pat-display-time="from-now: true"
datetime="${modified}"
title="${python: context.toLocalizedTime(modified, long_format=True)}"
>Modified</span>
</span>
</tal:dates>

Expand Down