add async context to acquire advisory locks#1208
Open
nilbacardit26 wants to merge 7 commits into
Open
Conversation
nilbacardit26
requested review from
bloodbare,
masipcat and
vangheem
as code owners
bloodbare
reviewed
Jun 9, 2026
bloodbare
left a comment
bloodbare
left a comment
Member
There was a problem hiding this comment.
As its not a core DB functionallity used on guillotina, maybe can be an external utility. G is designed to not need the locks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to lock an object to prevent concurrent modifications by other transactions. I've added this piece of code to use pessimistic advisory locking, using an async context manager.