bug(lambda): retain repository name for unknown git providers#6668
Open
zyzzmohit wants to merge 3 commits intopipe-cd:masterfrom
Open
bug(lambda): retain repository name for unknown git providers#6668zyzzmohit wants to merge 3 commits intopipe-cd:masterfrom
zyzzmohit wants to merge 3 commits intopipe-cd:masterfrom
Conversation
Signed-off-by: zyzzmohit <mohitray949@gmail.com>
…epoPath Signed-off-by: zyzzmohit <mohitray949@gmail.com>
auto-merge was automatically disabled
April 22, 2026 19:29
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
In
pkg/app/piped/platformprovider/lambda/function.go, theFindArtifactVersionsfunction attempts to parse the Git URL to generate a commit hyperlink for Lambda Source Code deployments. If it encounters a Git host it doesn't instantly recognize (like AWS CodeCommit or an internal Git server), it formerly fell into adefaultcase that completely wiped out both thegitURLhyperlink AND therepoPath. This PR removes the line zeroing outrepoPath, safely retaining the parsed repository path as the artifact name fallback when the Git provider's hyperlink format is visually unknown.Why we need it:
Zeroing out the
repoPathcaused theArtifactVersion.Nameto become empty, resulting in completely blank artifact layers surfacing within the PipeCD web UI. By safely preserving therepoPath, PipeCD can correctly identify and display the source repository path during deployments even if it can't hyperlink the commit hash itself.Which issue(s) this PR fixes:
Fixes #6666
Does this PR introduce a user-facing change?:
Yes.
Users loading AWS Lambda configurations backed by unknown / self-hosted Git providers will now see their repository correctly displayed in the PipeCD UI.