Fix Agent close hanging#934
Draft
JoTurk wants to merge 1 commit into
Draft
Conversation
Abort started candidate i/o before waiting for the task loop to stop. this prevents close from deadblocking when a task is blocked in WriteTo
Member
Author
|
@boks1971 I'll get this improved ready for review + regressions tests by tomorrow. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #934 +/- ##
==========================================
- Coverage 88.51% 88.42% -0.09%
==========================================
Files 46 46
Lines 5973 6014 +41
==========================================
+ Hits 5287 5318 +31
- Misses 473 480 +7
- Partials 213 216 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Abort started candidate i/o before waiting for the task loop to stop.
this prevents close from deadblocking when a task is blocked in WriteTo
This is a fix i have been testing for a few days it's missing regression test and some improvements.