flash: handle TiCI estimate count RPC#10826
flash: handle TiCI estimate count RPC#10826wshwsh12 wants to merge 4 commits intopingcap:feature/ftsfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What problem does this PR solve?
Issue Number: None
Problem Summary:
TiDB needs TiFlash to expose TiCI-side estimate count so the optimizer can use sampled TiCI fulltext cardinality instead of relying only on local planner estimates.
What is changed and how it works?
Check List
Tests
Manual test:
tici-estimate-skew-20260426-2240.EXPLAIN SELECT COUNT(*) FROM estimate_skew WHERE MATCH(content) AGAINST ('heavyhit' IN BOOLEAN MODE);.4321; exact match count was4000; total table row count was9400.GetEstimateTiCICount done, est_count=4321and TiCIEstimateCountResult { estimated_total_count: 4321, ... }.Side effects
Documentation
Release note