sessionctx: restore tidb_paging_size_bytes default to 0 - #70052
Conversation
Keep the Resource Control scope notes and the tested 4 MiB guidance so operators can still opt in explicitly, but leave byte-budget paging disabled by default. Signed-off-by: JmPotato <github@ipotato.me>
|
@YuhaoZhang00: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughThe default for ChangesPaging Default
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sync with pingcap/tidb#70052: keep byte-budget paging disabled by default, and note 4 MiB as a candidate value when explicitly enabling it. Signed-off-by: JmPotato <github@ipotato.me>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #70052 +/- ##
================================================
- Coverage 76.3266% 73.9390% -2.3877%
================================================
Files 2041 2058 +17
Lines 559579 578881 +19302
================================================
+ Hits 427108 428019 +911
- Misses 131570 150506 +18936
+ Partials 901 356 -545
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
yudongusa
left a comment
There was a problem hiding this comment.
Please open a document PR on this.
Please take a look at pingcap/docs-cn#21752. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rleungx, yudongusa, YuhaoZhang00 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-nextgen-202603 |
|
@JmPotato: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #68085
Problem Summary:
#69868 changed the default of
tidb_paging_size_bytesfrom0to 4 MiB. After further consideration, keep byte-budget paging opt-in by default to avoid surprising behavior changes for clusters that have not explicitly enabled this path. Operators can still set a non-zero value when needed.What changed and how does it work?
DefPagingSizeBytes/tidb_paging_size_bytesdefault from 4 MiB back to0(disabled).This intentionally does not remove the SET_VAR hint support or the
scope documentation introduced around #69868.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit
tidb_paging_size_bytesto0, disabling byte-budget paging by default.