Skip to content

tiproxy: support multiple external pd clusters#6831

Draft
YangKeao wants to merge 1 commit intopingcap:mainfrom
YangKeao:feature/tiproxy-external-pd-clusters
Draft

tiproxy: support multiple external pd clusters#6831
YangKeao wants to merge 1 commit intopingcap:mainfrom
YangKeao:feature/tiproxy-external-pd-clusters

Conversation

@YangKeao
Copy link
Copy Markdown
Member

After pingcap/tiproxy#1126, TiProxy supports multiple external pd clusters. Here I modified the tidb-operator to support to define the external pd clusters for a tiproxy deployment:

  1. Generate the correct TiProxy config according to the newly added Spec.
  2. Support to listen to a range of port.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot Bot commented Apr 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign z2665 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot requested a review from shonge April 16, 2026 12:51
@github-actions github-actions Bot added the v2 for operator v2 label Apr 16, 2026
@ti-chi-bot ti-chi-bot Bot added the size/XXL label Apr 16, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 80.70175% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.31%. Comparing base (f1c9aea) to head (1985513).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6831      +/-   ##
==========================================
+ Coverage   37.16%   37.31%   +0.14%     
==========================================
  Files         390      390              
  Lines       22360    22410      +50     
==========================================
+ Hits         8310     8362      +52     
+ Misses      14050    14048       -2     
Flag Coverage Δ
unittest 37.31% <80.70%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@YangKeao YangKeao force-pushed the feature/tiproxy-external-pd-clusters branch from 9ead4fa to 32b6e95 Compare April 16, 2026 13:06
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the feature/tiproxy-external-pd-clusters branch from 32b6e95 to 1985513 Compare April 16, 2026 15:25
@YangKeao YangKeao marked this pull request as draft April 17, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants