cmek split 2/8: TiKV encryption metadata HTTP client (#4571) - #5859
Conversation
Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
- Remove JSON decoding fallback for encryption meta responses - Use protobuf directly as the only supported format - Simplify error handling by removing redundant JSON decode attempts - Clean up logging by removing response format field - Update protobuf import to use standard package alias Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
This reverts commit fc6c88b.
Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenfyzhong The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #4571
What problem does this PR solve?
Issue Number: ref #3943
This is split PR 2/8 from #3955.
What is changed and how it works?
This PR adds TiKV-side encryption metadata retrieval:
This PR focuses only on metadata retrieval and parsing, and does not yet wire server lifecycle.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No direct user-facing behavior change in this split; it introduces a client used by later PRs.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
Summary by CodeRabbit
New Features
Tests