This repository was archived by the owner on Nov 24, 2023. It is now read-only.
pessimistic: record latest done ddl to handle conflict #1626
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| // Copyright 2021 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package pessimism | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
|
|
||
| "go.etcd.io/etcd/clientv3" | ||
|
|
||
| "github.com/pingcap/dm/dm/common" | ||
| "github.com/pingcap/dm/pkg/etcdutil" | ||
| ) | ||
|
|
||
| // putLatestDoneDDLsOp returns a PUT etcd operation for latest done ddls. | ||
| // This operation should often be sent by DM-master. | ||
| func putLatestDoneDDLsOp(lockID string, ddls []string) (clientv3.Op, error) { | ||
| data, err := json.Marshal(ddls) | ||
| if err != nil { | ||
| return clientv3.Op{}, err | ||
| } | ||
| key := common.ShardDDLPessimismDDLsKeyAdapter.Encode(lockID) | ||
|
|
||
| return clientv3.OpPut(key, string(data)), nil | ||
| } | ||
|
|
||
| // PutLatestDoneDDLs puts the last done shard DDL ddls into etcd. | ||
| func PutLatestDoneDDLs(cli *clientv3.Client, lockID string, ddls []string) (int64, error) { | ||
|
|
||
| data, err := json.Marshal(ddls) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| value := string(data) | ||
| key := common.ShardDDLPessimismDDLsKeyAdapter.Encode(lockID) | ||
|
|
||
| ctx, cancel := context.WithTimeout(cli.Ctx(), etcdutil.DefaultRequestTimeout) | ||
| defer cancel() | ||
|
|
||
| resp, err := cli.Put(ctx, key, value) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| return resp.Header.Revision, nil | ||
| } | ||
|
|
||
| // GetAllLatestDoneDDLs gets all last done shard DDL ddls in etcd currently. | ||
| // k/v: lockID -> DDLs | ||
| // This function should often be called by DM-master. | ||
| func GetAllLatestDoneDDLs(cli *clientv3.Client) (map[string][]string, int64, error) { | ||
| ctx, cancel := context.WithTimeout(cli.Ctx(), etcdutil.DefaultRequestTimeout) | ||
| defer cancel() | ||
|
|
||
| resp, err := cli.Get(ctx, common.ShardDDLPessimismDDLsKeyAdapter.Path(), clientv3.WithPrefix()) | ||
| if err != nil { | ||
| return nil, 0, err | ||
| } | ||
|
|
||
| ddlsMap := make(map[string][]string, len(resp.Kvs)) | ||
| for _, kv := range resp.Kvs { | ||
| var ddls []string | ||
| if err2 := json.Unmarshal(kv.Value, &ddls); err2 != nil { | ||
| return nil, 0, err2 | ||
| } | ||
| keys, err2 := common.ShardDDLPessimismDDLsKeyAdapter.Decode(string(kv.Key)) | ||
| if err2 != nil { | ||
| return nil, 0, err2 | ||
| } | ||
| lockID := keys[0] | ||
|
|
||
| ddlsMap[lockID] = ddls | ||
| } | ||
|
|
||
| return ddlsMap, resp.Header.Revision, nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // Copyright 2021 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package pessimism | ||
|
|
||
| import ( | ||
| . "github.com/pingcap/check" | ||
| ) | ||
|
|
||
| func (t *testForEtcd) TestDDLsEtcd(c *C) { | ||
| defer clearTestInfoOperation(c) | ||
|
|
||
| var ( | ||
| ID1 = "test1-`foo`.`bar`" | ||
| ID2 = "test2-`foo`.`bar`" | ||
| DDLs1 = []string{"ALTER TABLE bar ADD COLUMN c1 INT"} | ||
| DDLs2 = []string{"ALTER TABLE bar ADD COLUMN c2 INT"} | ||
| ) | ||
|
|
||
| // put the same keys twice. | ||
| rev1, err := PutLatestDoneDDLs(etcdTestCli, ID1, DDLs1) | ||
| c.Assert(err, IsNil) | ||
| rev2, err := PutLatestDoneDDLs(etcdTestCli, ID1, DDLs1) | ||
| c.Assert(err, IsNil) | ||
| c.Assert(rev2, Greater, rev1) | ||
|
|
||
| // put another DDLs | ||
| rev3, err := PutLatestDoneDDLs(etcdTestCli, ID1, DDLs2) | ||
| c.Assert(err, IsNil) | ||
| c.Assert(rev3, Greater, rev2) | ||
|
|
||
| // put for another lock | ||
| rev4, err := PutLatestDoneDDLs(etcdTestCli, ID2, DDLs1) | ||
| c.Assert(err, IsNil) | ||
| c.Assert(rev4, Greater, rev3) | ||
|
|
||
| // get all ddls. | ||
| latestDoneDDLsMap, rev5, err := GetAllLatestDoneDDLs(etcdTestCli) | ||
| c.Assert(err, IsNil) | ||
| c.Assert(rev5, Equals, rev4) | ||
| c.Assert(latestDoneDDLsMap, HasLen, 2) | ||
| c.Assert(latestDoneDDLsMap, HasKey, ID1) | ||
| c.Assert(latestDoneDDLsMap, HasKey, ID2) | ||
| c.Assert(latestDoneDDLsMap[ID1], DeepEquals, DDLs2) | ||
| c.Assert(latestDoneDDLsMap[ID2], DeepEquals, DDLs1) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.