Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ Cookies.prototype.set = function(name, value, opts) {

pushCookie(headers, cookie)

if (opts && signed) {
if (signed) {
if (!this.keys) throw new Error('.keys required for signed cookies');
cookie.value = this.keys.sign(cookie.toString())
cookie.name += ".sig"
Expand Down
23 changes: 23 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,29 @@ describe('new Cookies(req, res, [options])', function () {
})

describe('"signed" option', function () {
describe('when omitted', function () {
it('should default to signed when .keys are present', function (done) {
var opts = { keys: ['keyboard cat'] }

request(createServer(opts, setCookieHandler('foo', 'bar')))
.get('/')
.expect(200)
.expect(shouldSetCookieCount(2))
.expect(shouldSetCookieToValue('foo', 'bar'))
.expect(shouldSetCookieToValue('foo.sig', 'iW2fuCIzk9Cg_rqLT1CAqrtdWs8'))
.end(done)
})

it('should not set additional .sig cookie when .keys are not present', function (done) {
request(createServer(setCookieHandler('foo', 'bar')))
.get('/')
.expect(200)
.expect(shouldSetCookieCount(1))
.expect(shouldSetCookieToValue('foo', 'bar'))
.end(done)
})
})

describe('when true', function () {
it('should throw without .keys', function (done) {
request(createServer(setCookieHandler('foo', 'bar', { signed: true })))
Expand Down