[diffs/edit] tokenizer cache optimization - #1070
Open
ije wants to merge 1 commit into
Open
Conversation
Avoid invalidating unchanged bracket metadata after state-neutral edits. Extend the tokenizer benchmark and add regression coverage.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ije
changed the title
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, every edit discarded all cached bracket metadata from the edited line to the end of the document—even when tokenization proved that the downstream state was unchanged.
Example
Changing
1to100does not affect the TextMate state after that line. The highlighting below it remains valid, but the old implementation still deleted its cached string, comment, and regular-expression ranges.A later bracket lookup on a distant line therefore had to invoke the grammar again to rebuild metadata that was still valid.
New behavior
This is safe because unchanged text tokenized from an identical starting state produces identical bracket classifications.
Benchmark
The benchmark primes a 100,000-line cache, edits line 0, and queries the final line.
The measured 47% improvement applies specifically to this cache-invalidation scenario, not to overall tokenizer performance. The primary benefit is eliminating unnecessary grammar work after ordinary state-neutral edits.