Fix running installer tests twice for Elixir 1.19#6724
Closed
rhcarvalho wants to merge 1 commit into
Closed
Conversation
rhcarvalho
force-pushed
the
fix-installer-tests-dup
branch
from
073b81b to
1291caf
Compare
Both the integration test script and the ci.yml mix_test job were responsible for running installer tests, such that the same tests were run twice for Elixir 1.19. Since running the tests as part of a job provides better visibility, remove the installer test execution from the integration test script and opt-in to run the installer tests also on Elixir 1.15 as part of the mix_test job (previously was run by the test.sh script).
rhcarvalho
force-pushed
the
fix-installer-tests-dup
branch
from
1291caf to
43d9343
Compare
Contributor
Author
|
@SteffenDE alternatively I'm considering a separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the integration test script and the ci.yml mix_test job were responsible for running installer tests, such that the same tests were run twice for Elixir 1.19.
Since running the tests as part of a job provides better visibility, remove the installer test execution from the integration test script and opt-in to run the installer tests also on Elixir 1.15 as part of the mix_test job (previously was run by the test.sh script).
Extracted from bumping requirement for new apps (1.15->1.17) #6713 (comment), so as to keep the diff focused and easier to review.