(pshapp, auth): use TCSADRAIN instead of TCSAFLUSH for termios setting#265
Open
julianuziemblo wants to merge 1 commit into
Open
(pshapp, auth): use TCSADRAIN instead of TCSAFLUSH for termios setting#265julianuziemblo wants to merge 1 commit into
julianuziemblo wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the terminal attribute configuration in psh/pshapp/pshapp.c to use TCSADRAIN instead of TCSAFLUSH when enabling raw mode. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
julianuziemblo
changed the title
julianuziemblo
force-pushed
the
julianuziemblo/RTOS-1355
branch
from
7f8ebc5 to
df9775c
Compare
Until now, before every command, input was going to be flushed (which was not implemented in libtty). When it is implemented, input before parsing a command should not be flushed as we don't want to lose any characters from before the prompt is displayed to the user. YT: RTOS-1355
julianuziemblo
force-pushed
the
julianuziemblo/RTOS-1355
branch
from
df9775c to
fc38ad3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YT: RTOS-1355
Description
Until now, before every command, input was going to be flushed (which was not implemented in libtty). When it is implemented though, input from before the parsing of a command is started should not be flushed as we don't want to lose any characters from before the prompt is displayed to the user.
From what I've seen, e.g. GNU bash also does TCSADRAIN instead of TCSAFLUSH when setting termios attributes.
Motivation and Context
Connected to phoenix-rtos/phoenix-rtos-devices#671, which implements flushing/draining the input/output buffers on TCSETS/TCSETSW/TCSETSF underlying ioctl commands. It became apparent then that we're losing characters that were inputed before the prompt appeared.
Types of changes
How Has This Been Tested?
Checklist:
Special treatment