[DO NOT MERGE] add enet tests#1361
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @julianuziemblo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the lwIP configuration for the ia32-generic-qemu project by enabling the LWIP_NETPACKET option. This change is a new feature that is necessary to support ongoing development in a related test suite. In addition to the functional change, I also tidied up the formatting of the configuration file to enhance its readability.
Highlights
- LWIP_NETPACKET Enablement: I've enabled the LWIP_NETPACKET option in the lwIP configuration for the ia32-generic-qemu project. This is a crucial step for supporting network packet functionality.
- Configuration File Formatting: While making the functional change, I also took the opportunity to reformat many of the existing #define statements in the lwipopts.h file. This improves the readability and consistency of the configuration file.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request enables LWIP_NETPACKET for the ia32-generic-qemu project, which is a necessary feature. The accompanying formatting changes to align the macros improve readability. I've added a couple of suggestions to make the alignment more consistent throughout the file. Overall, a good change.
Unit Test Results 1 files ± 0 483 suites +4 41m 55s ⏱️ - 1m 40s Results for commit bd1f692. ± Comparison against base commit 81ca139. This pull request removes 207 and adds 219 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
* libphoenix 755e3ea...480f66a (4): > phoenix/ethtool: add interface loopback get/set handling > ioctl: add SIOCETHTOOL > ioctl: serialize special ioctls in userspace > sys/sockios: fix code formatting * phoenix-rtos-kernel e35fd78...57e992f (1): > ioctl: serialize special ioctls outside of kernel * phoenix-rtos-lwip 8d0b26f...fb0fbb6 (11): > drivers/rtl8139cp: add selftest > drivers: pull out enet_selftest to separate file > drivers/rtl8139cp: add interface loopback get/set handling > drivers/ephy: fix loopback enable on RTL8201FI-VC-CG/RTL8211FDI-CG > drivers/imx-enet: add interface loopback get/set handling > drivers: add ethtool ioctl handling by the driver > port/sockets: adjust to special ioctl changes > port/netpacket: fix raw socket send > drivers/(bdring, pktmem): remove redundant ethpad add/remove > drivers/pktmem: fix pbuf payload alignment > wi-fi: whd_wifi_get_associated_client_list() buffer fix > submodule update * phoenix-rtos-ports 0c97d59...d87156c (3): > ethtool: add interface loopback get/set function > add ethtool port > coremark_pro: use smaller thread stack size on low-memory targets * phoenix-rtos-tests 6489639...39b6064 (6): > ioctl: add tests for ethtool ioctl > ioctl: add special ioctl tests > trunner: improve formatting of multi-line subresult messages > libc/math: uncomment special values checks > libc/math: enable subnormals values test for sqrt() > libc/math: reduce precision strictness for sqrt() JIRA: RTOS-1014
julianuziemblo
force-pushed
the
julianuziemblo/test-enet
branch
from
f3064d4 to
f1f0911
Compare
julianuziemblo
changed the title
julianuziemblo
force-pushed
the
julianuziemblo/test-enet
branch
2 times, most recently
from
e033aa8 to
bd1f692
Compare
JIRA: RTOS-508
julianuziemblo
force-pushed
the
julianuziemblo/test-enet
branch
from
bd1f692 to
71df827
Compare
julianuziemblo
changed the base branch from
master
to
julianuziemblo/RTOS-1014
julianuziemblo
force-pushed
the
julianuziemblo/test-enet
branch
from
71df827 to
9632663
Compare
JIRA: RTOS-508
julianuziemblo
force-pushed
the
julianuziemblo/test-enet
branch
from
9632663 to
94e876d
Compare
julianuziemblo
force-pushed
the
julianuziemblo/RTOS-1014
branch
5 times, most recently
from
29faf59 to
0ec6253
Compare
julianuziemblo
force-pushed
the
julianuziemblo/RTOS-1014
branch
5 times, most recently
from
1b40abe to
fa9df67
Compare
julianuziemblo
force-pushed
the
julianuziemblo/RTOS-1014
branch
11 times, most recently
from
062a014 to
3c59f9a
Compare
1 participant
JIRA: RTOS-508
Description
Motivation and Context
Types of changes
How Has This Been Tested?
ia32-generic-qemu,armv7m7-imxrt106x-evk,armv7a7-imx6ull-evk.Checklist:
Special treatment