Skip to content

lwip-tests: create port enabling run of lwip tests#72

Open
adamdebek wants to merge 2 commits into
masterfrom
adamdebek/lwip-tests
Open

lwip-tests: create port enabling run of lwip tests#72
adamdebek wants to merge 2 commits into
masterfrom
adamdebek/lwip-tests

Conversation

@adamdebek

Copy link
Copy Markdown
Contributor

JIRA: CI-329

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Comment thread lwip-tests/patch/sio.patch Outdated
@adamdebek adamdebek force-pushed the adamdebek/lwip-tests branch from 76cff89 to ebecbb7 Compare January 11, 2024 12:58
@github-actions

github-actions Bot commented Jan 11, 2024

Copy link
Copy Markdown

Unit Test Results

6 410 tests  +408   5 776 ✅ +408   33m 27s ⏱️ + 3m 19s
  354 suites +  8     634 💤 ±  0 
    1 files   ±  0       0 ❌ ±  0 

Results for commit d721a48. ± Comparison against base commit 7a859f9.

♻️ This comment has been updated with latest results.

@nalajcie nalajcie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointed out some issues

Comment thread lwip-tests/build.sh Outdated
Comment thread lwip-tests/patch/Common-allports.patch Outdated
Comment thread lwip-tests/patch/Common-allports.patch Outdated
Comment thread lwip-tests/patch/Common-allports.patch Outdated
Comment thread lwip-tests/patch/Common-allports.patch Outdated
Comment thread lwip-tests/patch/Makefile.patch Outdated
Comment thread lwip-tests/build.sh Outdated
mkdir -p "${PREFIX_CHECK_BUILD}/include"
if [ ! -f "{$PREFIX_CHECK_BUILD}/config.h" ]; then
CHECK_CFLAGS="-std=gnu99 -I${PREFIX_CHECK_BUILD}/include"
(cd "$PREFIX_CHECK_SRC" && autoreconf -i -v -f && \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is autoreconf really necessary? (shouldn't be)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no default configure script so I need to generate it using autoreconf

Comment thread lwip-tests/build.sh Outdated
Comment thread lwip-tests/build.sh Outdated
b_log "Building lwip-test"

LWIP_CONTRIB_COMMIT="35b011d4cf4c4b480f8859c456587a884ec9d287"
LWIP_CONTRIB_PKG_URL="https://github.com/particle-iot/lwip-contrib/archive/${LWIP_CONTRIB_COMMIT}.tar.gz"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use release tag, maybe use official git repo (eg. https://git.savannah.nongnu.org/cgit/lwip/lwip-contrib.git/snapshot/lwip-contrib-STABLE-2_1_0_RELEASE.tar.gz)?

is contrib only needed for unix port? (host testing?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Comment thread lwip-tests/build.sh Outdated
@adamdebek adamdebek force-pushed the adamdebek/lwip-tests branch from ebecbb7 to 484d8c8 Compare January 15, 2024 16:12
Comment thread lwip-tests/build.sh Outdated
@adamdebek adamdebek force-pushed the adamdebek/lwip-tests branch from 484d8c8 to 8655c66 Compare January 15, 2024 16:14
@adamdebek adamdebek requested a review from nalajcie January 15, 2024 16:30
@adamdebek adamdebek force-pushed the adamdebek/lwip-tests branch from 8655c66 to d721a48 Compare January 16, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants