Skip to content

Add micro-ecc port definition specification#142

Draft
jarekfoh wants to merge 1 commit into
masterfrom
jarekfoh/add-micro-ecc-port
Draft

Add micro-ecc port definition specification#142
jarekfoh wants to merge 1 commit into
masterfrom
jarekfoh/add-micro-ecc-port

Conversation

@jarekfoh

@jarekfoh jarekfoh commented Jul 9, 2026

Copy link
Copy Markdown

YT: ISC-260

Description

Added micro-ecc library to ports.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv8m33-mcn94x-frdm, ia32-generic-pc, armv7m4-stm32l4x6-nucleo.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@jarekfoh jarekfoh requested a review from a team July 9, 2026 13:05
@jarekfoh jarekfoh self-assigned this Jul 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new port definition file micro-ecc/port.def.sh for the micro-ecc library. The feedback recommends addressing style inconsistencies by using tabs instead of spaces for indentation, appending a trailing slash to src_path to match project conventions, and using cp -a instead of cp for more robust file copying.

Comment thread micro-ecc/port.def.sh
Comment thread micro-ecc/port.def.sh
Comment thread micro-ecc/port.def.sh Outdated
@jarekfoh jarekfoh force-pushed the jarekfoh/add-micro-ecc-port branch from 4282dcc to a2b3bcd Compare July 10, 2026 07:11
@jarekfoh jarekfoh marked this pull request as draft July 10, 2026 07:57
@jarekfoh jarekfoh force-pushed the jarekfoh/add-micro-ecc-port branch from a2b3bcd to b99f9df Compare July 10, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants