sensors: generalise lps22 pressure sensor for HH and DF models#663
Draft
radekszewczyk01 wants to merge 1 commit into
Draft
sensors: generalise lps22 pressure sensor for HH and DF models#663radekszewczyk01 wants to merge 1 commit into
radekszewczyk01 wants to merge 1 commit into
Conversation
radekszewczyk01
force-pushed
the
radekszewczyk01/baro_lps22_generalise
branch
from
25755e2 to
0f19f06
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for the LPS22DF barometric sensor variant by refactoring the driver to accommodate both LPS22HH and LPS22DF models. The changes include model-specific register definitions, an updated sensor identification process, and dedicated initialization routines for each variant. A review comment points out an unreachable return statement in the lps22xx_hwSetup function that should be removed for code clarity.
| return -1; | ||
| } | ||
|
|
||
| return -1; |
There was a problem hiding this comment.
This return statement is unreachable because the switch block above handles all possible cases (including default) and returns from the function in every branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: PP-404
Generalise driver for lps22xx pressure sensor series.
Description
Generalise driver for lps22xx pressure sensor series.
Motivation and Context
This change is required in order to use lps22hh or lps22df depending on target.
Types of changes
How Has This Been Tested?
Checklist:
Special treatment