imx6ull: rngb driver#329
Open
DawidSzpejna wants to merge 1 commit into
Open
Conversation
e2db24f to
657ff8c
Compare
657ff8c to
d093d50
Compare
d093d50 to
0a00b07
Compare
nalajcie
requested changes
Jan 11, 2023
nalajcie
left a comment
Member
There was a problem hiding this comment.
pointed out some things which might be improved ;)
gerard5
reviewed
Jan 12, 2023
gerard5
reviewed
Jan 16, 2023
0a00b07 to
011cc1a
Compare
aff855f to
6772360
Compare
gerard5
reviewed
Feb 27, 2023
gerard5
left a comment
Contributor
There was a problem hiding this comment.
Partial review, remarks for rngb_intr() function.
6772360 to
2e40ab7
Compare
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
ziemleszcz
reviewed
Jun 21, 2023
2e40ab7 to
86f7d40
Compare
86f7d40 to
cae9caf
Compare
ziemleszcz
reviewed
Jun 23, 2023
cae9caf to
f97a5a2
Compare
kemonats
reviewed
Jun 25, 2023
f97a5a2 to
8144e90
Compare
ziemleszcz
reviewed
Jul 17, 2023
ziemleszcz
reviewed
Jul 17, 2023
ziemleszcz
reviewed
Jul 17, 2023
The driver starts by creating basic structures for a phonix driver. Then it sets flags for tests of rngb and seeding, sequentially. The last things is waiting for system messaga. JIRA: RTOS-317
4a0e286 to
dcf8a36
Compare
gerard5
reviewed
Jul 21, 2023
| /* Run self test */ | ||
| *(common_rngb.base + rng_cmd) = 0x1; | ||
| mutexLock(common_rngb.lock); | ||
| while (common_rngb.intr_st == 0) { |
Contributor
There was a problem hiding this comment.
Here we are waiting for whether the self-test has finished or failed and not for all statuses, so shouldn't it be?
Suggested change
| while (common_rngb.intr_st == 0) { | |
| while ((common_rngb.intr_st & (SELF_TEST_DONE | ERROR_OCCURRED)) == 0) { | |
| /* Run seeding */ | ||
| *(common_rngb.base + rng_cmd) = 0x2; | ||
| mutexLock(common_rngb.lock); | ||
| while (common_rngb.intr_st == 0) { |
Contributor
There was a problem hiding this comment.
Here we are waiting for whether the seeding has finished or failed and not for all statuses, so shouldn't it be?
Suggested change
| while (common_rngb.intr_st == 0) { | |
| while ((common_rngb.intr_st & (SEED_DONE | ERROR_OCCURRED)) == 0) { | |
| } | ||
|
|
||
| handleMsg(NULL); | ||
|
|
Contributor
There was a problem hiding this comment.
System cleanup is missing, any required resources freeing - if handleMsg() returns on msgRecv() error, also return 0 is misleading if handleMsg() terminates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add driver for rngb on imx6ull to support TRNG
Description
Motivation and Context
For imx6ull, trng wans't supported
Types of changes
How Has This Been Tested?
Checklist:
Special treatment