ad7779: apply a sync pulse after configuration#303
Open
jsarzy wants to merge 1 commit into
Open
Conversation
jsarzy
commented
Oct 6, 2022
| continue; | ||
| } | ||
|
|
||
| if ((status[16] & INIT_COMPLETE_BIT) && (status[13] & RESET_DETECTED_BIT)) { |
Contributor
Author
There was a problem hiding this comment.
Perhaps a less error-prone and more readable approach would be to use a struct with fields instead the array with magic indices.
gerard5
reviewed
Oct 6, 2022
JIRA: DTR-342
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use a START pulse to generate an internal SYNC_IN pulse after each configuration. Additionaly, I removed the START pulse and long sleeps after device reboot. I have tested this on imx6ull and imxrt based architectures and it seems to work well. Hang-ups do not occur.
Types of changes
How Has This Been Tested?
Checklist:
Special treatment