Add new implementation of math library (libmcs), remove math library dependency from strtod.c#460
Merged
Merged
Conversation
Summary of ChangesHello @ayoopierre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the project's mathematical capabilities by integrating a new, robust math library, 'libmcs'. This change not only broadens the range of supported mathematical functions and improves compliance with industry standards but also introduces a more modular and configurable approach to managing math implementations. The existing 'libphoenix' math code has been reorganized to coexist, providing flexibility for different project requirements and hardware constraints. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the libmcs math library (v1.3.0) as an alternative implementation for critical systems and refactors the existing libphoenix math implementation into a separate directory. It also removes the math library dependency from strtod.c. The changes include a new libm/Makefile to select between implementations and a configure script for libmcs. My review identified a few critical logic errors in the libm/Makefile and the libphoenix implementation, as well as a syntax bug in the configure script.
ayoopierre
force-pushed
the
ayopierre/add_libcsm
branch
2 times, most recently
from
February 19, 2026 15:13
ebb5432 to
4d39af1
Compare
ayoopierre
force-pushed
the
ayopierre/add_libcsm
branch
from
April 3, 2026 11:03
4d39af1 to
6e002fe
Compare
lukileczo
reviewed
Apr 3, 2026
ayoopierre
force-pushed
the
ayopierre/add_libcsm
branch
from
April 3, 2026 12:22
6e002fe to
1169285
Compare
|
@ayoopierre please resolve this conflict and let's merge this |
added 2 commits
July 7, 2026 10:51
JIRA: RTOS-1132
JIRA: RTOS-1132
ayoopierre
force-pushed
the
ayopierre/add_libcsm
branch
from
July 7, 2026 09:01
1169285 to
482cf7d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+6
to
+7
| find libm/common libm/complex* libm/math* -name "*.c" | grep -v "fenv.c" > sw-quality/misra-c/files.lnt | ||
| wine ~/lint-nt.exe sw-quality/std.lnt sw-quality/misra-c/files.lnt | sed 's#\\#/#g' > sw-quality/misra-c/lint.txt || true |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| find libm/common libm/complex* libm/math* -name "*.c" | grep -v "fenv.c" > sw-quality/misra-c/files.lnt | |
| wine ~/lint-nt.exe sw-quality/std.lnt sw-quality/misra-c/files.lnt | sed 's#\\#/#g' > sw-quality/misra-c/lint.txt || true | |
| find libm/common libm/complex* libm/math* -name "*.c" | grep -v "fenv.c" >sw-quality/misra-c/files.lnt | |
| wine ~/lint-nt.exe sw-quality/std.lnt sw-quality/misra-c/files.lnt | sed 's#\\#/#g' >sw-quality/misra-c/lint.txt || true |
Member
|
kber-ps
reviewed
Jul 8, 2026
| * | ||
| * This file is part of Phoenix-RTOS. | ||
| * | ||
| * %LICENSE% |
There was a problem hiding this comment.
Please use SPDX-License-Identifier: BSD-3-Clause
kber-ps
requested changes
Jul 8, 2026
kber-ps
left a comment
kber-ps
left a comment
There was a problem hiding this comment.
Let's just apply new license name convention and we can merge
ayoopierre
force-pushed
the
ayopierre/add_libcsm
branch
3 times, most recently
from
July 8, 2026 16:16
1112019 to
7b255c8
Compare
JIRA: RTOS-1132
ayoopierre
force-pushed
the
ayopierre/add_libcsm
branch
from
July 9, 2026 08:52
7b255c8 to
7610e74
Compare
Member
|
Okay, few things of note here. First off, why wasn't this consulted with the core team, nor @phoenix-rtos/phoenix-core was tagged for review. Secondly, I'm not sure that vendoring all of this stuff is the way to go around things. I'm not completely against it (monorepo ftw), but it seems to go against our current practices, meaning, submoduling the hell out of everything we can. This change prompted @dependabot to now create useless spammy Python dep-bump PR's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new implementation of math library (libmcs v1.3.0).
Description
Add new implementation of math library (libmcs), move libphoenix implementation of math library, remove dependency of strtod.c on math library. Current configuration will fail to compile on ia32 because of patches on micropython applied before compilation.
Motivation and Context
Adding complete math library implementation with extensions for critical applications
Types of changes
How Has This Been Tested?
Checklist:
Special treatment