fix(draft): show suggested nonbasic lands in deck

[matthewevans]

Summary by CodeRabbit

• Bug Fixes
  • Improved suggested deck construction so drafted nonbasic fixing lands are included in the main deck.
  • Land recommendations now contain only additional lands that can be added.
  • Preserved draft-pool order and correctly handled duplicate cards.
  • Prevented off-color or unrecognized nonbasic lands from being added.
  • Ensured suggested decks maintain the requested size.
  • Improved handling when card information is unavailable.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c6df0aa-53b8-403c-9193-48b72dbf0a5f

📥 Commits

Reviewing files that changed from the base of the PR and between c62bae7 and 0a3d225.

📒 Files selected for processing (1)

• crates/draft-wasm/src/suggest.rs

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/draft-wasm/src/suggest.rs

---

📝 Walkthrough

Walkthrough

The suggestion logic places drafted nonbasic fixing lands in main_deck. The lands map now contains only addable cards. Selection preserves pool order and supports duplicate drafted copies. Tests cover color eligibility, exact deck size, and missing card databases.

Changes

Drafted land classification

Layer / File(s)	Summary
Classify drafted fixing lands crates/draft-wasm/src/suggest.rs	SuggestedDeck records drafted nonbasic lands in main_deck. Selection preserves pool order, decrements duplicate counts, and keeps lands limited to addable cards.
Validate fixing land output crates/draft-wasm/src/suggest.rs	Tests verify on-color inclusion, off-color exclusion, absence from lands, exact deck size, duplicate copies, and no-database behavior.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

• phase-rs/phase#6663: Modifies limited-deck land handling and deck land accounting.
• phase-rs/phase#6670: Modifies nonbasic fixing-land classification in suggest.rs.
• phase-rs/phase#6711: Places drafted nonbasic fixing lands in main_deck and updates related tests.

Suggested labels: needs-maintainer

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: displaying suggested nonbasic lands in the draft deck.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ship/fixdraft-show-suggested-nonbasic-lands-in-deck

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

crates/draft-wasm/src/suggest.rs (1)

481-540: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Add a duplicate drafted-land test.

The tests do not create two distinct DraftCardInstance values with the same selected nonbasic-land name. Add a test that verifies both copies enter main_deck and each copy replaces one basic land. This validates the count-decrement logic in Lines 115-127.

As per path instructions, CLAUDE.md requires focused tests for “duplicate drafted copies.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/draft-wasm/src/suggest.rs` around lines 481 - 540, Add a focused test
alongside the existing nonbasic-land tests that constructs two distinct
DraftCardInstance values with the same selected nonbasic land name, runs the
suggestion flow, and asserts both copies appear in main_deck. Also verify each
copy replaces a basic by asserting the combined spell and land count remains
min_deck_size and the basic-land allocation is reduced by two.

Source: Path instructions

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@crates/draft-wasm/src/suggest.rs`:
- Around line 481-540: Add a focused test alongside the existing nonbasic-land
tests that constructs two distinct DraftCardInstance values with the same
selected nonbasic land name, runs the suggestion flow, and asserts both copies
appear in main_deck. Also verify each copy replaces a basic by asserting the
combined spell and land count remains min_deck_size and the basic-land
allocation is reduced by two.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 40b500ee-ca34-4c79-8fb0-e138f13744dd

📥 Commits

Reviewing files that changed from the base of the PR and between 8c6e1d1 and c62bae7.

📒 Files selected for processing (1)

• crates/draft-wasm/src/suggest.rs