Skip to content

chore(ai): re-baseline the decision-cost perf gate onto post-#6826 cost #7053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewevans merged 1 commit into from
Aug 6, 2026
Merged

chore(ai): re-baseline the decision-cost perf gate onto post-#6826 cost #7053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions crates/phase-ai/baselines/perf-baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schema_version": 4,
"git_sha": "1e7943098bad",
"git_sha": "7f5f0b4a3656",
"card_data_hash": "670a4a14a501f5ae5df43f832676c4556104234d",
"base_seed": 2654435769,
"action_cap": 3000,
Expand All @@ -16,30 +16,30 @@
"cached_auto_tap_source_rejects": 0,
"cached_auto_tap_source_reuses": 37,
"combat_shadow_block_scans": 0,
"crew_eligibility_scans": 12027,
"crew_eligibility_scans": 11015,
"granted_ability_provider_scans": 0,
"layers_escalated": 73,
"layers_full_eval": 15877,
"layers_full_eval": 5464,
"layers_incremental": 395,
"legal_actions_spell_cost_sweeps": 10,
"legend_rule_mode_gate_scans": 27535,
"mana_aura_trigger_scans": 53208,
"legend_rule_mode_gate_scans": 19703,
"mana_aura_trigger_scans": 40836,
"mana_display_sweeps": 247,
"mana_display_swept_objects": 2455,
"priority_cast_probe_builds": 10,
"restriction_static_exact_scans": 0,
"restriction_static_mode_gate_scans": 155747,
"sba_battlefield_snapshot_builds": 27462,
"sba_empty_battlefield_short_circuits": 35,
"restriction_static_mode_gate_scans": 110891,
"sba_battlefield_snapshot_builds": 19626,
"sba_empty_battlefield_short_circuits": 31,
"spell_keyword_grant_scans": 0,
"stack_batch_candidates": 0,
"stack_batch_observer_refusals": 0,
"stack_batch_plans": 0,
"stack_batched_entries": 0,
"stack_inert_noop_batches": 0,
"stack_inert_noop_entries": 0,
"state_clone_for_legality": 19342,
"state_clone_for_legality": 11099,
"static_full_scans": 0
Comment on lines +19 to 42

@coderabbitai coderabbitai Bot Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Keep the baseline refresh limited to the intended counters.

The PR objective names four counters, but Lines [19-42] also change values such as crew_eligibility_scans, layers_escalated, layers_incremental, legend_rule_mode_gate_scans, mana_aura_trigger_scans, and sba_empty_battlefield_short_circuits. These unrelated changes can move regression gates without corresponding measurement evidence.

Restore unrelated counters, or document and validate each additional update with the same immutable snapshot and paired-seed process.

As per path instructions: preserve the existing schema and make only the intended measured-value, threshold, and baseline SHA updates.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/phase-ai/baselines/perf-baseline.json` around lines 19 - 42, Limit the
baseline refresh in the performance baseline JSON to the four counters named by
the PR objective, along with the intended threshold and baseline SHA updates.
Restore unrelated values such as crew_eligibility_scans, layers_escalated,
layers_incremental, legend_rule_mode_gate_scans, mana_aura_trigger_scans, and
sba_empty_battlefield_short_circuits; preserve the existing schema without
adding undocumented counter changes.

Source: Path instructions

},
"wall_clock_ms": 25331
"wall_clock_ms": 20942
}
Loading