fix(attach): honor protection attachment exemptions (#4964) #5015
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1400,13 +1400,30 @@ pub(crate) fn parse_continuous_modifications(text: &str) -> Vec<ContinuousModifi | |
| } | ||
| } | ||
| } else if let Some(keyword_text) = extract_keyword_clause(&unquoted_text) { | ||
| let (keyword_only, trailing_exemption) = | ||
| match super::oracle_nom::bridge::split_once_on_lower( | ||
| keyword_text, | ||
| &keyword_text.to_lowercase(), | ||
| ". ", | ||
| ) { | ||
| Some((first, rest)) | ||
| if rest.to_ascii_lowercase().contains("doesn't remove") | ||
| || rest.to_ascii_lowercase().contains("does not remove") => | ||
| { | ||
| (first, Some(rest.trim())) | ||
| } | ||
| _ => (keyword_text, None), | ||
| }; | ||
|
Comment on lines
+1581
to
+1593
Contributor
There was a problem hiding this comment. [HIGH] Verbatim string matching and Why it matters: Using Suggested fix: Use a dedicated nom parser to recognize the trailing exemption prose. let (keyword_only, trailing_exemption) =
match super::oracle_nom::bridge::split_once_on_lower(
keyword_text,
&keyword_text.to_lowercase(),
". ",
) {
Some((first, rest)) if parse_protection_exemption(rest.trim()).is_ok() => {
(first, Some(rest.trim()))
}
_ => (keyword_text, None),
};References
|
||
| for part in split_keyword_list(keyword_only.trim().trim_end_matches('.')) { | ||
| push_grant_clause_modifications( | ||
| &mut modifications, | ||
| part.as_ref(), | ||
| where_x_expression.as_deref(), | ||
| ); | ||
| } | ||
| if let Some(trailing) = trailing_exemption { | ||
| push_protection_attachment_exemption_modifications(&mut modifications, trailing); | ||
| } | ||
| } | ||
|
|
||
| // CR 613.1f: Pre-quote keyword recovery for compound lines like Swashbuckler's | ||
|
|
@@ -1461,11 +1478,12 @@ pub(crate) fn push_grant_clause_modifications( | |
| // parse_quoted_ability_modifications at :798) before extract_keyword_clause | ||
| // runs, so any ". " here can only introduce a trailing inert prose sentence | ||
| // (e.g. Benevolent Blessing's SBA-exemption "This effect doesn't remove ..."). | ||
| // Strip it from the keyword token, but emit the matching protection-attachment | ||
| // exemption static when recognized. | ||
| let (part, trailing_exemption) = | ||
| match super::oracle_nom::bridge::split_once_on_lower(part, &part.to_lowercase(), ". ") { | ||
| Some((first, rest)) => (first, Some(rest.trim())), | ||
| None => (part, None), | ||
| }; | ||
|
|
||
| let part_trimmed = part.trim().trim_end_matches('.'); | ||
|
|
@@ -1538,6 +1556,9 @@ pub(crate) fn push_grant_clause_modifications( | |
|
|
||
| if let Some(kw) = map_keyword(part_trimmed) { | ||
| modifications.push(ContinuousModification::AddKeyword { keyword: kw }); | ||
| if let Some(trailing) = trailing_exemption { | ||
| push_protection_attachment_exemption_modifications(modifications, trailing); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
|
|
@@ -1565,6 +1586,24 @@ pub(crate) fn push_grant_clause_modifications( | |
| } | ||
| } | ||
|
|
||
| fn push_protection_attachment_exemption_modifications( | ||
| modifications: &mut Vec<ContinuousModification>, | ||
| trailing: &str, | ||
| ) { | ||
| let lower = trailing.to_lowercase(); | ||
| if lower.contains("doesn't remove this aura") || lower.contains("does not remove this aura") { | ||
| modifications.push(ContinuousModification::AddStaticMode { | ||
| mode: StaticMode::ProtectionDoesntRemoveThisAura, | ||
| }); | ||
| } else if lower.contains("doesn't remove auras and equipment you control") | ||
| || lower.contains("does not remove auras and equipment you control") | ||
| { | ||
| modifications.push(ContinuousModification::AddStaticMode { | ||
| mode: StaticMode::ProtectionDoesntRemoveControlledAttachments, | ||
| }); | ||
| } | ||
| } | ||
|
Comment on lines
+1865
to
+1872
Contributor
There was a problem hiding this comment. [HIGH] Verbatim string matching used for parsing Oracle phrases. Why it matters: Using verbatim string matching for compound phrases bypasses the robust nom-based parser and creates fragile matches, violating the repository rule on Oracle phrase parsing. Suggested fix: Decompose compound phrases into modular, reusable parsers for constituent parts (such as the subject, negation, and target) and compose them using idiomatic combinator aggregates (like nested fn parse_protection_exemption(input: &str) -> nom::IResult<&str, StaticMode> {
use nom::{
branch::alt,
bytes::complete::tag_no_case,
combinator::value,
sequence::tuple,
};
let effect_parser = tag_no_case("this effect ");
let negation_parser = alt((tag_no_case("doesn't remove "), tag_no_case("does not remove ")));
let this_aura = value(
StaticMode::ProtectionDoesntRemoveThisAura,
tag_no_case("this aura")
);
let controlled_attachments = value(
StaticMode::ProtectionDoesntRemoveControlledAttachments,
tag_no_case("auras and equipment you control that are already attached to it")
);
let (input, (_, _, mode)) = tuple((effect_parser, negation_parser, alt((this_aura, controlled_attachments))))(input)?;
Ok((input, mode))
}
fn push_protection_attachment_exemption_modifications(
modifications: &mut Vec<ContinuousModification>,
trailing: &str,
) {
if let Ok((_, mode)) = parse_protection_exemption(trailing) {
modifications.push(ContinuousModification::AddStaticMode { mode });
}
}References
|
||
|
|
||
| /// Extract quoted ability text from Oracle text and parse each into a typed AbilityDefinition. | ||
| /// | ||
| /// Quoted abilities like `"{T}: Add two mana of any one color."` are parsed by splitting | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.