Modify how the doubleclick bug fix works#19583
Merged
jecisc merged 1 commit intopharo-project:Pharo14from Apr 24, 2026
Merged
Conversation
…erent rows can trigger also a doubleclick event) by registering the first mousedown: event and comparing. The old fix was causing that a list inside a scroll pane was not receiving double click events. While is highly probably that the real bug resides on the bubbling on events, this thing is easy and works :) fixes pharo-project#14168 fixes pharo-spec/NewTools#1364
Member
Author
|
the test failures worries me but they are not related with this change :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(that two fast clicks on slightly different rows can trigger also a doubleclick event) by registering the first mousedown: event and comparing.
The old fix was causing that a list inside a scroll pane was not receiving double click events. While is highly probably that the real bug resides on the bubbling on events, this thing is easy and works :)
fixes #14168
fixes pharo-spec/NewTools#1364