Skip to content

Fix: Trait new should have nil superclass #19571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcusDenker wants to merge 1 commit into
base: Pharo14
Choose a base branch
from
+12 −3
Open

Fix: Trait new should have nil superclass #19571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Fuel-Core/FLTraitCluster.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ FLTraitCluster >> materializePostInstance: aTrait with: aDecoder [

aTrait
initialize;
"#initialize sets Object as the superclass
but the superclass of traits is nil"
basicSuperclass: nil;
setName: name;
environment: environment.

Expand Down
6 changes: 6 additions & 0 deletions src/Traits-Tests/TraitTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,12 @@ TraitTest >> testTraitHaveUsersInstanceVariable [
self assert: (aClass slotNamed: #users) definingClass equals: t1
]

{ #category : 'tests' }
TraitTest >> testTraitInitialize [
"this tests that #intialize is correctly setting the superclass to nil"
self assert: Trait new superclass isNil
]

{ #category : 'tests' }
TraitTest >> testTraitRemoval [

Expand Down
6 changes: 6 additions & 0 deletions src/Traits/Trait.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ Trait >> expandedDefinitionStringFor: aPrinter [
^ aPrinter expandedTraitDefinitionString
]

{ #category : 'initialization' }
Trait >> initialize [
super initialize.
self basicSuperclass: nil
]

{ #category : 'testing' }
Trait >> isBaseTrait [
<reflection: 'Class structural inspection - Class kind testing'>
Expand Down