Skip to content

modularisation FileSystem #19568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanMalenge wants to merge 31 commits into
base: Pharo14
Choose a base branch
from
Open

modularisation FileSystem #19568

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
79e0599
add FileSystem
NathanMalenge Apr 17, 2026
11b519c
Merge branch 'Pharo14' of github.com:pharo-project/pharo into FileSystem
NathanMalenge Apr 17, 2026
593f483
Refactoring: remove StringTests extensions from FileSystem-Core-Tests
NathanMalenge Apr 17, 2026
a23ddd3
Refactor: add UnifiedFFI dependency to FileSystem tests resolve LibC …
NathanMalenge Apr 17, 2026
745e70b
changed grouptest name
NathanMalenge Apr 17, 2026
2ebee07
Merge branch 'Pharo14' of github.com:pharo-project/pharo into FileSystem
NathanMalenge Apr 17, 2026
fd173bd
add a dependency to System-OSEnvironments
NathanMalenge Apr 17, 2026
84ba5e7
Fix: use UnifiedFFI minimal group for FileSystem tests
NathanMalenge Apr 17, 2026
69f655f
Fix: remove external baseline requirement from package spec
NathanMalenge Apr 17, 2026
1b5af80
add reference to UnifiedFFi and delete group TestFFI
NathanMalenge Apr 17, 2026
1baf9c7
replacement of testFFI by Tests
NathanMalenge Apr 17, 2026
540e56d
add loading guideline for baslineofUnifiedFFi
NathanMalenge Apr 17, 2026
50a8df0
Merge branch 'Pharo14' of github.com:pharo-project/pharo into FileSystem
NathanMalenge Apr 20, 2026
99873b4
add dependendy to OS-Platforms
NathanMalenge Apr 20, 2026
f3fcf3e
fix boostrap bug
NathanMalenge Apr 20, 2026
9c8622f
loading default
NathanMalenge Apr 20, 2026
9971b88
add dependency to osPltforms in UnifiedFFi instead of FileSystem
NathanMalenge Apr 20, 2026
329741a
trying to fix dependency issue
NathanMalenge Apr 20, 2026
62c4618
add dependency
NathanMalenge Apr 20, 2026
ed58063
Merge branch 'Pharo14' of github.com:pharo-project/pharo into FileSystem
NathanMalenge Apr 20, 2026
6a71db3
change package of the method because there was a cycling dependency
NathanMalenge Apr 20, 2026
19191c3
moving these methods to avoid circular dependencies
NathanMalenge Apr 20, 2026
1c2834b
changing package again to avoid dependency
NathanMalenge Apr 20, 2026
179653d
Merge branch 'Pharo14' of github.com:pharo-project/pharo into FileSystem
NathanMalenge Apr 20, 2026
d4a5380
add missing dependency
NathanMalenge Apr 20, 2026
1fcd889
changed the package of the method and now loading core instead of min…
NathanMalenge Apr 20, 2026
5276c39
loading baselineOfThreadedFFI to add dependency
NathanMalenge Apr 20, 2026
ccb5f54
Merge branch 'Pharo14' of github.com:pharo-project/pharo into FileSystem
NathanMalenge Apr 20, 2026
f89e78a
delete ref to threadedffi
NathanMalenge Apr 21, 2026
e39252f
Merge branch 'Pharo14' of github.com:pharo-project/pharo into FileSystem
NathanMalenge Apr 21, 2026
7ce1e02
Merge branch 'Pharo14' into FileSystem
NathanMalenge Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ def bootstrapImage(){
isoTesters['System-SessionManager'] = { defineIsoTestStage("System-SessionManager", "SystemSessionManager", "Tests", "\'System-SessionManager-Tests\'") }

isoTesters['System-Platforms'] = { defineIsoTestStage("System-Platforms", "SystemPlatforms", "Tests", "\'System-Platforms-Tests\'") }
isoTesters['FileSystem'] = { defineIsoTestStage("FileSystem", "FileSystem", "TestsWithFFI", "\'FileSystem-Core-Tests\' \'FileSystem-Disk-Tests\' \'FileSystem-Tests-Attributes\'") }
parallel isoTesters

stage ("Full Image") {
Expand Down
13 changes: 8 additions & 5 deletions src/BaselineOfFileSystem/BaselineOfFileSystem.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,20 @@ BaselineOfFileSystem >> baseline: spec [
<baseline>
spec for: #common do: [
spec
baseline: 'UnifiedFFI' with: [ spec repository: (self packageRepositoryURLForSpec: spec) ];

package: 'FFI-Kernel';
package: 'FileSystem-Path';
package: 'FileSystem-Core';
package: 'FileSystem-Disk';
package: 'FileSystem-Disk' ;
package: 'System-Sources-Files';

package: 'FileSystem-Core-Tests';
package: 'FileSystem-Disk-Tests';
package: 'FileSystem-Core-Tests' with: [ spec requires: #('FileSystem-Core')];
package: 'FileSystem-Disk-Tests' ;
package: 'FileSystem-Tests-Attributes'.

spec
group: 'Core' with: {'FFI-Kernel'. 'FileSystem-Path'. 'FileSystem-Core'. 'FileSystem-Disk'. 'System-Sources-Files'};
group: 'Tests' with: { 'FileSystem-Core-Tests'. 'FileSystem-Disk-Tests'. 'FileSystem-Tests-Attributes' } ]
group: 'Core' with: { 'FFI-Kernel'. 'FileSystem-Path'. 'FileSystem-Core'. 'FileSystem-Disk'. 'System-Sources-Files'};
group: 'Tests' with: { 'FileSystem-Core-Tests'. 'FileSystem-Disk-Tests'. 'FileSystem-Tests-Attributes' } ;
group: 'TestsWithFFI' with: #('Tests' 'UnifiedFFI').]
Copy link
Copy Markdown
Member

@guillep guillep Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a different group, we should say that FileSystem-Core-Tests depends on UnifiedFFI, right?

]
15 changes: 10 additions & 5 deletions ...System-Core-Tests/StringTest.extension.st → ...System-Core-Tests/FileStringTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
Extension { #name : 'StringTest' }
Class {
#name : 'FileStringTest',
#superclass : 'TestCase',
#category : 'FileSystem-Core-Tests',
#package : 'FileSystem-Core-Tests'
}

{ #category : '*FileSystem-Core-Tests' }
StringTest >> testAsFileLocatorOrReferenceReturnsALocatorWhenStringRefersToAKnownOrigin [
{ #category : 'tests' }
FileStringTest >> testAsFileLocatorOrReferenceReturnsALocatorWhenStringRefersToAKnownOrigin [
| pathString locator |
pathString := (FileLocator home / 'foo') fullName.

Expand All @@ -15,8 +20,8 @@ StringTest >> testAsFileLocatorOrReferenceReturnsALocatorWhenStringRefersToAKnow
equals: pathString
]

{ #category : '*FileSystem-Core-Tests' }
StringTest >> testAsFileLocatorOrReferenceReturnsAReferenceWhenStringDoesNotReferToAKnownOrigin [
{ #category : 'tests' }
FileStringTest >> testAsFileLocatorOrReferenceReturnsAReferenceWhenStringDoesNotReferToAKnownOrigin [
| fileRef result |
fileRef := '/foo' asFileReference.

Expand Down