Skip to content

Fix browse commit in iceberg repository. #19388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexisCnockaert wants to merge 2 commits into
base: Pharo14
Choose a base branch
from
+15 −9
Open

Fix browse commit in iceberg repository. #19388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7a7339
Fix browse commit in iceberg repository.
AlexisCnockaert Mar 6, 2026
410f2bc
slightly better code
AlexisCnockaert Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Calypso-Ring/ClyRing2Environment.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ ClyRing2Environment >> defaultClassCompiler [
^ self class compiler
]

{ #category : 'accessing' }
ClyRing2Environment >> definedClassesInPackage: aPackage [

^ aPackage definedClasses
]

{ #category : 'accessing' }
ClyRing2Environment >> environment [
^ environment
Expand Down
18 changes: 9 additions & 9 deletions src/Calypso-SystemTools-Core/ClyClassTableDecorator.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ ClyClassTableDecorator class >> decorateTableCell: anItemCellMorph of: aDataSour
| labelMorphExtension cmt |
labelMorphExtension := anItemCellMorph label assureExtension.
cmt := aDataSourceItem actualObject comment.
cmt
ifEmpty: [ cmt := ClyUncommentedItemTableDecorator balloonText ]
ifNotEmpty: [ | lines |
lines := cmt lines.
cmt := lines first: (lines size min: 3).
cmt := String cr join: cmt. ].
labelMorphExtension balloonText: cmt


Copy link
Copy Markdown
Member

@Ducasse Ducasse Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when is the case that cmt does not understand content?
Could not we get all objects returned there to understand comment (I mean solving the cause instead of the consequence)?

((cmt respondsTo: #content)
ifTrue: [ cmt := cmt content ]
ifFalse: [ cmt ]) ifEmpty: [ cmt := ClyUncommentedItemTableDecorator balloonText ] ifNotEmpty: [
| lines |
lines := cmt lines.
cmt := lines first: (lines size min: 3).
cmt := String cr join: cmt ].
labelMorphExtension balloonText: cmt
]

{ #category : 'decoration' }
Expand Down