Skip to content

Updates for PHP 8.4 compatibility#285

Open
ReadyCloudSuite wants to merge 3 commits into
phacility:masterfrom
ReadyCloudSuite:8.4
Open

Updates for PHP 8.4 compatibility#285
ReadyCloudSuite wants to merge 3 commits into
phacility:masterfrom
ReadyCloudSuite:8.4

Conversation

@ReadyCloudSuite

@ReadyCloudSuite ReadyCloudSuite commented Dec 23, 2024

Copy link
Copy Markdown
  • Fixed FutureProxy::__construct(): Implicitly marking parameter $proxied as nullable is deprecated, the explicit nullable type must be used instead.
  • Fixed Implicitly marking parameter $proxied as nullable is deprecated, the explicit nullable type must be used instead.
  • Fixed Passing null to parameter #1 ($status) of type string|int is deprecated.

…ied as nullable is deprecated, the explicit nullable type must be used instead"
…d, the explicit nullable type must be used instead" errors.
@ReadyCloudSuite ReadyCloudSuite changed the title Fixed "FutureProxy::__construct(): Implicitly marking parameter $proxied as nullable is deprecated, the explicit nullable type must be used instead" Updates for PHP 8.4 compatibility Dec 23, 2024
@gregtatum

Copy link
Copy Markdown

Thanks, I applied this patch and arcanist is working again. I also had to turn off deprecation warnings to be able to parse the JSON output.

diff --git a/bin/arc b/bin/arc
index 51528ca0..696f8191 100755
--- a/bin/arc
+++ b/bin/arc
@@ -1,5 +1,6 @@
 #!/usr/bin/env php
 <?php
+error_reporting(E_ALL ^ E_DEPRECATED);
 
 if (function_exists('pcntl_async_signals')) {
   pcntl_async_signals(true);

@semsudin

semsudin commented Mar 3, 2025

Copy link
Copy Markdown

Please can somebody merge this to master.

2 similar comments
@dushaoshuai

Copy link
Copy Markdown

Please can somebody merge this to master.

@ez4bk

ez4bk commented Jul 8, 2025

Copy link
Copy Markdown

Please can somebody merge this to master.

@cheack

cheack commented Jul 8, 2025

Copy link
Copy Markdown

@semsudin @dushaoshuai @ez4bk
Phabricator is officially dead. You guys should try https://github.com/phorgeit/arcanist instead.

@gregtatum

gregtatum commented Sep 25, 2025

Copy link
Copy Markdown

Lol, I downgraded php as a short term mitigation. 8.4 is officially broken in this repo.

brew install php@8.3
brew link --overwrite --force php@8.3
php --version
PHP 8.3.25 (cli) (built: Aug 26 2025 15:05:30) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.25, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.25, Copyright (c), by Zend Technologies

8.3 is still supported... for now.
https://www.php.net/supported-versions.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants