Skip to content

Remove checkpoint hook patch; no longer used#472

Open
mason-sharp wants to merge 1 commit into
mainfrom
remove-checkpoint-hook
Open

Remove checkpoint hook patch; no longer used#472
mason-sharp wants to merge 1 commit into
mainfrom
remove-checkpoint-hook

Conversation

@mason-sharp
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 19df634c-f006-4e68-9bb5-c79e227178b4

📥 Commits

Reviewing files that changed from the base of the PR and between a570737 and 3263de1.

📒 Files selected for processing (4)
  • patches/15/pg15-040-checkpoint-hook.diff
  • patches/16/pg16-040-checkpoint-hook.diff
  • patches/17/pg17-040-checkpoint-hook.diff
  • patches/18/pg18-040-checkpoint-hook.diff
💤 Files with no reviewable changes (4)
  • patches/18/pg18-040-checkpoint-hook.diff
  • patches/15/pg15-040-checkpoint-hook.diff
  • patches/17/pg17-040-checkpoint-hook.diff
  • patches/16/pg16-040-checkpoint-hook.diff

📝 Walkthrough

Walkthrough

This PR adds a checkpoint hook mechanism to PostgreSQL's checkpoint subsystem across versions 15, 17, and 18. Each version introduces a new Checkpoint_hook_type callback and a global Checkpoint_hook variable, enabling external extensions to register code that runs after buffer flush but before fsync/sync during checkpoint processing.

Changes

Checkpoint Hook Mechanism

Layer / File(s) Summary
PG15 checkpoint hook
patches/15/pg15-040-checkpoint-hook.diff
Checkpoint_hook_type callback and Checkpoint_hook global variable declared in xlog.h and invoked in CheckPointGuts after buffer flush.
PG17 checkpoint hook
patches/17/pg17-040-checkpoint-hook.diff
Checkpoint_hook_type and Checkpoint_hook exported in header; hook invoked in CheckPointGuts between buffer processing and fsync phase.
PG18 checkpoint hook
patches/18/pg18-040-checkpoint-hook.diff
Checkpoint_hook_type and PGDLLIMPORT Checkpoint_hook initialized to NULL; hook invoked in CheckPointGuts between buffer flush and fsync phase.

Poem

🐰 A checkpoint hook hops into the code,
Four PostgreSQL paths now share the load,
After buffers flush and before syncs align,
Extensions can dance at this checkpoint fine!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, which is insufficient context for understanding the rationale behind removing these patches. Add a description explaining why the checkpoint hook patches are no longer used and any migration/deprecation context.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing checkpoint hook patches that are no longer used.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-checkpoint-hook

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant