Bump a few gem versions - #11
Open
randyleighton wants to merge 38 commits into
Open
Conversation
Upgrade eycap
Bump rails, multi_json, and several test related gems. Also remove, refactor and/or bump a few other gems in the Gemfile. Needed to tweak the spec_helper a bit after this to support the changes.
Moved to features dir as per new version of Capybara. Also changed matchers as the within syntax was failing for odd reasons. Lastly modified the test that uses Selenium to use a local Firefox instance instead of going out to Perry's old http://translatable-qa.herokuapp.com/ app sitting on Heroku.
Bump rails and various json gems
It's only intended to work around an issue with ruby 1.8. See: http://ph7spot.com/musings/system-timer
The selenium driver was having issues. Using a headless browser for testing is way nicer anyway.
A lot of gems dropped support for ruby 1.8 in later versions, so now we can finally upgrade.
Upgrade to Ruby 1.9
Ruby 1.9 removes '.' from the load path
Unfortunately, this introduced chattiness in the test suite. Something is printing "error : string is not in UTF-8" to STDOUT during feature specs around cp1252 encoded input. I suspect it's one of the test gems.
Convert all translation input to UTF-8
Bump gems to deal with security vulnerabilities
delegates to redis_reload gem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We needed to bump the rubyracer gem to get bundle to complete. The goal of this is to do a bump of nokogiri for recent security fixes in the gem. The nokogiri gem has been implemented in all other G5 apps except a few with no issues yet.
We are not sure how to proceed to test this locally,