Conversation
Contributor
|
I think the really tricky part here is actually getting the screenshots into the PR comments. We'd need some kind of an article to accompany the PR so that we can test the workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Automatically run article screenshot previews for PRs and fix workflow conditions that prevented comments/skips from behaving correctly.
Why
Issue #408 asks for screenshots on new article pull requests, but the current workflow needs a manual label, fails when no article files are changed, and never posts comments due to an event-condition mismatch.
How
*/incoming/*.podand*/articles/*.podchanges.pull_request_targetevents.Testing
perl -MYAML::XS=LoadFile -e 'LoadFile(".github/workflows/screenshot.yml")'prove -lr tQuality Report
Changes: 1 file changed, 14 insertions(+), 13 deletions(-)
Code scan: clean
Tests: skipped
Branch hygiene: 1 issue(s)
Generated by Kōan post-mission quality pipeline