PG-2424 PostgreSQL 19 support - #806
Merged
Merged
Conversation
artemgavrilov
force-pushed
the
PG-2424-pg19
branch
3 times, most recently
from
July 31, 2026 14:07
19a2402 to
fed60d2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
- Coverage 88.57% 88.08% -0.49%
==========================================
Files 3 3
Lines 1304 1318 +14
Branches 180 183 +3
==========================================
+ Hits 1155 1161 +6
- Misses 75 80 +5
- Partials 74 77 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
artemgavrilov
force-pushed
the
PG-2424-pg19
branch
from
July 31, 2026 15:35
fed60d2 to
481ccb5
Compare
artemgavrilov
marked this pull request as ready for review
July 31, 2026 16:17
artemgavrilov
force-pushed
the
PG-2424-pg19
branch
from
July 31, 2026 16:25
0c199bc to
2a116fe
Compare
jeltz
requested changes
Aug 3, 2026
jeltz
left a comment
jeltz
left a comment
Contributor
There was a problem hiding this comment.
I have not reviewed what actually changed in PGSS.
This was referenced Aug 3, 2026
Closed
Contributor
|
Do we need to support |
artemgavrilov
force-pushed
the
PG-2424-pg19
branch
4 times, most recently
from
August 4, 2026 17:04
958ddb5 to
fed3a0b
Compare
Contributor
Author
Added |
|
what are the concerns regarding changes in PGSS that are being referenced here? |
Contributor
|
@adeshthack The main thing was |
jeltz
requested changes
Aug 5, 2026
Make pg_stat_monitor compilable against PostgreSQL 19 PostgreSQL 19 optimized SELECT ... INTO statements execution(ce8d5fe), so some of them are no longer tracked by pg_stat_statements/pg_stat_monitor. So we update level tracking test to address this change. Build and test CI workflow required timeout increase as PG 19 requires slightly more time.
There are no PostgreSQL 19 packages yet, so add this version only to source based workflows.
pg_stat_statements introduces two new coutners in PostgreSQL 19: - generic_plan_calls - custom_plan_calls These counters track how many times a prepared statement was executed using a generic or custom plan. Backport them to pg_stat_monitor.
PostgreSQL 19 exposes ComputeConstantLengths function, so there is no more reasons to compute constant lenght with our own implemenation.
In PostgreSQL 19 some pg_stat_statements tests got updates. Backport them to pg_stat_monitor.
Backport the upstream pg_stat_statements fix (commit b1635c16669) from PostgreSQL 18. Mark same-location duplicates with length = -1 before the squashed check.
Mark property graphs with * the same way as we do for views.
Condition had and issue where it was keeping all subqueries, but it should keep only subqueries that are views or property graphs. Rewrite it with better condition: perminfoindex is non-zero for all types of RTEs that we need.
artemgavrilov
force-pushed
the
PG-2424-pg19
branch
from
August 5, 2026 13:52
fed3a0b to
96a3336
Compare
yea sounds good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PG-2424
Description
https://www.postgresql.org/docs/19/release-19.html#RELEASE-19-PGSTATSTATEMENTS
postgres/postgres@REL_18_4...REL_19_BETA2
Links
Fixes #773