Conversation
|
Thank you for the contribution. You modified auto-generated code that will be rewritten after we run , ./utils/update-modules. Please add your changes into lib/QueryHistory.pm, then update modules in all tools as described in CONTRIBUTING.md |
svetasmirnova
left a comment
There was a problem hiding this comment.
Please update lib/QueryHistory.pm
My apologies for overlooking this. |
|
Changes look good for me, thank you! But MySQL user accounts consist of two parts: usernames and hosts. E.g., sveta@percona.com is not the same user as sveta@my.blog. Maybe it makes sense to store host part too? |
svetasmirnova
left a comment
There was a problem hiding this comment.
Please fix this stalled table name in the user manual part of the code too (query_review_history -> query_history).
Co-authored-by: Sveta Smirnova <svetasmirnova@users.noreply.github.com>
This is very good idea, Sveta. In this code change I have reused already available user data which doesn't contain host information. |
svetasmirnova
left a comment
There was a problem hiding this comment.
Host is defined as part of $ea->results->{'classes'}{$item}, so I do not think it will require rewriting the tool's core logic. I suggest adding it now, together with the new "user" column.
Please also fix formatting: Percona Toolkit uses 3 spaces for indentation.
Background
Idea behind this PR is to add information about DB users who executed a query to the history table. I've decided to add JSON column to store array of users for each query. There are probably more elegant solutions, but I wanted to keep "one table" concept.
Summary of changes