Skip to content

Patches for bugs introduced in 2.4 and 2.5 releases #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
missinglink merged 2 commits into from
Jun 23, 2025
Merged

Patches for bugs introduced in 2.4 and 2.5 releases #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0fa51e
Patches for bugs introduced in 2.4 and 2.5 releases
ianthetechie Feb 20, 2025
99ab9a1
Use blacklist; revert change to libpostal source file
ianthetechie Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classifier/scheme/venue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ module.exports = [
scheme: [
{
is: ['PlaceClassification', 'VenueClassification'],
not: ['StreetClassification']
not: ['StreetClassification', 'StreetSuffixClassification']
},
{
is: ['AlphaClassification'],
Expand Down
2 changes: 2 additions & 0 deletions resources/pelias/dictionaries/libpostal/nb/concatenated_suffixes_separable.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Causes a bunch of issues with Spanish addresses ("Calle" is a common prefix)
!alle
5 changes: 5 additions & 0 deletions test/address.esp.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ const testcase = (test, common) => {
{ street: 'Carrer d\'Aragó' }, { housenumber: '155' },
{ postcode: '08011' }, { locality: 'Barcelona' }
])

assert('Calle Principal 20 Barcelona', [
{ street: 'Calle Principal' }, { housenumber: '20' },
{ locality: 'Barcelona' }
])
}

module.exports.all = (tape, common) => {
Expand Down
5 changes: 5 additions & 0 deletions test/address.usa.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,11 @@ const testcase = (test, common) => {
// https://github.com/pelias/pelias/issues/912
assert('Jefferson Parish', [{ locality: 'Jefferson' }])
assert('Mills County', [{ locality: 'Mills' }])

// Partial admin match that triggered a regression in 2.5.0
assert('Main St Seattl', [
{ street: 'Main St' }
])
}

module.exports.all = (tape, common) => {
Expand Down