[madsiberian]

@C:/Users/Coder/AppData/Local/Temp/pr-body.md

---

Note

Low Risk
Additive provider wiring across build, CLI, and docs with targeted tests; no changes to auth, hooks, or existing provider behavior beyond new registry entries.

Overview
Adds ZCode as a first-class Impeccable provider so skills can install to .zcode/skills/ (project) or ~/.zcode/skills/ (global), with npx impeccable link --providers=zcode and the usual build/sync paths.

The build pipeline gets a zcode transformer config (.zcode dir, license/metadata frontmatter, version in metadata like Codex). Runtime treats ZCode like Codex for UX: $impeccable command prefix, Codex-style pinned shortcuts, and .agents fallback for skill discovery per harness docs.

Rust skills/context layers register .zcode in provider lists, aliases, install hints (~/.zcode), pin harness dirs, and content-hash normalization. Docs (README, HARNESSES, CLI contract, DEVELOP), issue/PR templates, and CI sync for .zcode/** are updated; tests cover name resolution and home-dir detection.

^{Reviewed by Cursor Bugbot for commit 7597c19. Bugbot is set up for automated code reviews on this repo. Configure here.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

Adds ZCode support across generated skills, CLI installs, runtime messages, and pinned shortcuts.

• Impeccable builds and documents skills for ZCode.
• ZCode installs are detected and use $impeccable shortcuts.

Review used the full PR diff because the current and previously reviewed commits have different merge bases with the target commit. Checks were based on source inspection; builds and tests were not run.

_{Reviews (7) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile}

[madsiberian]

Good catch — that was a transcription slip in the ZCode column rewrite, not an intended change: main had Yes (matching the DSH note and the dsh provider config emitting metadata), and my rebuild of the row copied the license/compatibility ending. Restored to Yes in 3cb1b7e, and verified per-cell that every other original cell in the table is byte-identical to main with only the ZCode column appended.

[pbakaus]

Thanks for taking the time to contribute. Impeccable is issue-first for outside contributions, and I could not find a relevant linked issue where a maintainer approved or requested this work. I’m closing this for now. Please open or join an issue, wait for explicit approval from @pbakaus or @abdulwahabone, and then open a fresh PR. This policy check was performed automatically by Codex; if it missed existing approval, please point a maintainer to it.

[abdulwahabone]

Reopened after approval on #1176. I reviewed the change against the ZCode source (zai-org/ZCode, Apache-2.0) rather than the docs, and the provider claims hold up: both skill roots, the .agents/skills companion root, the 1024-char description cap that drops the skill, the five recognized frontmatter keys, the flat line parser, and AGENTS.md at the project root and ~/.zcode/. The Rust and JS wiring mirrors the Vibe provider spot for spot. Nice work.

Before this merges, three groups of changes.

Accuracy

• The hooks note (HARNESSES.md and the providers.js comment) conflates two files. User-level hooks live in ~/.zcode/cli/config.json behind hooks.enabled; workspace .zcode/config.json hooks are documented as never executed, and the source gates them behind a per-user trust store. Simplest fix is to drop the sentence rather than correct it (see trims below).
• Prefix: ZCode invokes skills with $skill-name, the Codex convention, while the PR sets command_prefix: '/'. The slash panel also lists skills, so / works. If we switch to $, it is a three-place change: the utils.js placeholder, the Codex-only test in crates/context/src/provider.rs (command_prefix), and CODEX_HARNESSES in pin.rs. Paul's call; say which you picked in the PR body.

Trims, to keep the diff surgical

• Remove crates/skills/tests/zcode_detection_tests.rs. ZCode has no provider-specific detection code; it reaches detection through the generic PROVIDER_DIRS loop and the Hint::Home arm, and no plain-home provider has a detection test file. zcode_provider_resolves in providers.rs follows the OMP/DSH precedent and is enough. If you want one assertion that .zcode is in the hint table, fold a single case into install_detection_tests.rs, which already has the helpers.
• Shorten the providers.js zcode comment to two lines plus the docs link, matching the hermes and DSH entries. HARNESSES.md is the source of truth for capabilities.
• In the HARNESSES.md ZCode bullet, drop the hook-surface sentence and replace the two em dashes (docs/STYLE.md bans them).

Places a new provider touches that are missing here (compare the Qoder and DSH additions)

• docs/CLI-CONTRACT.md: PROVIDER_DIRS, aliases, GLOBAL_HARNESS_HINTS, and HARNESS_DIRS lists.
• crates/skills/src/bundle.rs: PROVIDER_PATH_RE.
• AGENTS.md: the tracked harness-folder list.
• .gitattributes: .zcode/** linguist-generated.
• docs/DEVELOP.md: the harness docs link list.
• .github/PULL_REQUEST_TEMPLATE.md and .github/ISSUE_TEMPLATE/feature_request.md: provider checklists.

Optional: version: is emitted by default and is not in ZCode's safe-key set, so zcode skills inspect reports safeToAutoLoad: no. Cosmetic only; versionInMetadata: true on the provider config would clear it.

AI assistance disclosure: this review was drafted with Claude Code under my direction, with the ZCode claims verified against the zai-org/ZCode source.

[madsiberian]

Review round addressed in 4fc7ddc — thanks for the thorough pass, and for verifying the claims against the ZCode source.

• Prefix: picked $ (the native ZCode convention, as with Codex) — also noted in the PR body. Three-place change: utils.js placeholder, provider.rs prefix selection, CODEX_HARNESSES in pin.rs.
• Hooks note dropped from HARNESSES.md; providers.js comment trimmed to two lines + docs link; em dashes replaced.
• Trims: zcode_detection_tests.rs removed; a single .zcode home-hint assertion folded into install_detection_tests.rs.
• Missing places added: CLI-CONTRACT.md (PROVIDER_DIRS, aliases, GLOBAL_HARNESS_HINTS, HARNESS_DIRS, scripts-path list, prefix note, provider-name list), bundle.rs PROVIDER_PATH_RE, AGENTS.md harness-folder list, .gitattributes linguist-generated, DEVELOP.md link, PR + issue template checklists.
• versionInMetadata: true — zcode skills inspect now reports safeToAutoLoad: yes.

Validation: cargo test -p impeccable-context -p impeccable-skills all green (incl. the folded hint test); default bun suite 477 pass / 2 fail, both pre-existing on this Windows box (launcher exec-bit, native component-review bundle). dist/zcode emission re-verified: version now rides inside metadata.

AI assistance disclosure: these fixes were prepared with a ZCode agent under my direction.

[madsiberian]

Fixed in 7597c19: the blank lines were merge-conflict-resolution leftovers around the Devin/ZCode rows; removed from both tables and the doubled blanks after the ZCode rows collapsed.

AI assistance disclosure: prepared with a ZCode agent under my direction.