Repository navigation
Name craft-floor in the launcher fallback; keep bans out of the brief override - #1153
Merged
Merged
Conversation
… override The launcher-unavailable fallback said only "follow applicable steps 2-3", and measured runs on that path never opened reference/craft-floor.md before the first UI edit (#744). Name the read explicitly. craft-floor.md line 3 said a pinned brief overrides anything in the file, which read as overriding the lines marked as bans (#984). Except them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 [Medium impact] The PR appears safe to merge; no new actionable issues remain. SummaryThe PR makes two small skill-text changes:
Since the previous review,
Reviews (2) · Last reviewed commit: "Note the named craft-floor fallback read..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
abdulwahabone
added a commit
that referenced
this pull request
Oct 24, 2026
A day of main comes in: the round-13 measurement defects (#1151) and the straggler fix (#1135), hidden product mockups (#1137), legal and footnote blocks (#1146), full-page evidence capture (#1149), the Tune value fixes (#1108, #1154), the launcher and ignore-boundary round (#1116), the craft-floor launcher fallback (#1153), the reference docs reconciliation (#1117), the CSP meta reference fix (#1145), keeping installed skills when the bundle is unreachable (#1144), the debuginfo cut (#1150), and the generated provider syncs. No source conflicts: the in-page bundle and five sweep goldens conflicted as generated files. The bundle was regenerated from the merged source with `cargo xtask bundle`; the sweep goldens are main's as they stand, since main carries them as accepted deltas in DELTAS.md (its own new fixtures are not recorded in them yet), and this branch's sweep entries are covered by its existing DELTAS entries the same way. Prepared with AI assistance (Claude Code). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two one-line skill-text fixes, approved by @pbakaus.
Launcher fallback names craft-floor (Refs #744). The "Launcher unavailable" paragraph in
skill/SKILL.src.mdsaid only "follow applicable steps 2–3". ktlesr measured 0 of 21 craft-floor reads before the first UI edit on that path (acceptEdits, where the launcher is refused). The fallback now names the read: "including reading reference/craft-floor.md immediately before any UI edit", the same wording step 3 uses.craft-floor line 3 no longer reads as overriding the bans (Refs #984). "A pinned brief or the committed visual world overrides anything here" now ends "except a line marked as a ban", so the eyebrow ban (and any other line marked as a ban) stays absolute, as decided in #984. PR #1117 handled the other #984 items.
Testing.
bun run buildpasses (skill prose validator clean).bun run test:skill-behavioris owed for these Setup-adjacent edits; Paul plans one combined run after #1114 and #1118 land, so it was not run here. No generated provider dirs are staged.Prepared by an AI agent (Claude Code) under instructions from @pbakaus.
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only skill instruction changes with no code, launcher, or harness assertion updates.
Overview
Two skill prose clarifications with no runtime or test assertion changes.
Launcher fallback (#744): When
impeccable contextcannot run, the fallback paragraph no longer relies on vague “follow applicable steps 2–3.” It now explicitly requires readingreference/craft-floor.mdimmediately before any UI edit—the same wording as Setup step 3—so agents on the denied-launcher path actually load the craft floor (outside measurement had 0/21 reads).Craft-floor hierarchy (#984): The opening line in
craft-floor.mdnow states that a pinned brief or committed visual world overrides craft-floor content except lines marked as a ban, so absolute bans (e.g. eyebrow ban) are not implied to be negotiable via the brief.Docs:
tests/skill-behavior/README.mdrecords the #744 motivation and notes scenario 19 assertions are unchanged; a combinedtest:skill-behaviorrerun is deferred.Reviewed by Cursor Bugbot for commit b7bd0ed. Bugbot is set up for automated code reviews on this repo. Configure here.