Ensure receiver properly handles malformed responses to mailbox - #1843
Merged
Conversation
Before this check any response that fell outside the size range could cause an overflow and crash the receiver's program. This is limited to anyone who knew the receiver's pk for a sesssion.
benalleng
changed the title
Collaborator
Coverage Report for CI Build 32896585921Coverage increased (+0.001%) to 86.719%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
benalleng
force-pushed
the
plaintext-padding-overflow
branch
from
August 25, 2026 20:02
5311ed8 to
95323bc
Compare
benalleng
force-pushed
the
plaintext-padding-overflow
branch
from
August 25, 2026 20:39
95323bc to
6d84a6c
Compare
benalleng
added a commit
to benalleng/rust-payjoin
that referenced
this pull request
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that any response that the receiver reads is within the payload size range preventing any panic due to an overflow.
Additionally in the case of an error this does not immediately close the session however I think this could be up to some debate whether these should be treated as fatal errors or not.dropped until we can answer #1844Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.