Skip to content

Bump python, javascript, and C# bindings for payjoin-1.0.0 #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacebear21 merged 4 commits into from
Aug 26, 2026
Merged

Bump python, javascript, and C# bindings for payjoin-1.0.0 #1831

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
edc3124
Allow build metadata in release tag verification
spacebear21 Aug 25, 2026
60da5fb
Prepare python payjoin 0.2.0 for PyPI
spacebear21 Aug 21, 2026
0576e49
Prepare javascript payjoin 0.2.0 for npm
spacebear21 Aug 21, 2026
830845e
Prepare C# Payjoin 0.1.0+payjoin-1.0.0 for NuGet
spacebear21 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions .github/actions/verify-tag-version/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
name: Verify tag version
description: >
Check that the pushed tag is the expected prefix followed by exactly the
version about to be published, refusing to publish on any mismatch.
Check that the pushed tag is the expected prefix followed by the version
about to be published, refusing to publish on any mismatch. Tags carry
the full `{version}+payjoin-{version}` string; when the packed version
has no build metadata (npm, PyPI, and NuGet artifacts cannot carry it),
the tag's metadata is stripped before comparing.
inputs:
tag-prefix:
description: Expected tag prefix, e.g. payjoin-csharp-
Expand Down Expand Up @@ -30,8 +33,16 @@ runs:
exit 1
fi
tag_version="${TAG#"$PREFIX"}"
if [[ $tag_version != "$VERSION" ]]; then
echo "::error::tag $TAG implies version $tag_version but the packed version is $VERSION; refusing to publish"
compare_version="$tag_version"
# A packed version without build metadata comes from a registry
# that cannot represent it, so the tag is compared with its
# metadata stripped; a packed version that carries metadata must
# match the tag exactly.
if [[ $VERSION != *+* ]]; then
compare_version="${tag_version%%+*}"
fi
Comment on lines +36 to +43

@spacebear21 spacebear21 Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit clunky but it seemed like the most straightforward way to enforce uniformity across tags (payjoin-{lang}-{version}+payjoin-{version}) despite some package managers not supporting the + syntax.

Open to suggestions for better ways to structure the release tags. The current approach took inspiration from https://gitlab.com/ark-bitcoin/bark-ffi-bindings/-/blob/master/RELEASE.md?ref_type=heads#versioning-per-language

if [[ $compare_version != "$VERSION" ]]; then
echo "::error::tag $TAG implies version $compare_version but the packed version is $VERSION; refusing to publish"
exit 1
fi
echo "version=$tag_version" >>"$GITHUB_OUTPUT"