-
Notifications
You must be signed in to change notification settings - Fork 110
Bump python, javascript, and C# bindings for payjoin-1.0.0 #1831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
edc3124
60da5fb
0576e49
830845e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <IsPackable>true</IsPackable> | ||
| <PackageId>Payjoin</PackageId> | ||
| <Version>0.24.0-preview.1</Version> | ||
| <Version>0.1.0+payjoin-1.0.0</Version> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you see any confusion with csharp always being a version behind? I know this is not technically the most correct semver but it seems annoying to always have this one minor version behind the others
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The way bark does versioning is: all downstream languages track the ffi version, so they're all in sync. IMO there are good reasons to keep each language's version independent. There may be releases affecting only one language, like if a particular bindings generator e.g. uniffi-dart comes out with an important fix. That doesn't warrant making releases in all the other languages just to keep the versions in sync. And in the future when we add support for a new language we probably want to start it at 0.1.0 anyway while it's still being experimented with. |
||
| <Title>Payjoin</Title> | ||
| <Authors>Payjoin Dev Kit Contributors</Authors> | ||
| <Description>C# bindings for payjoin-ffi, generated from rust-payjoin via UniFFI.</Description> | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels a bit clunky but it seemed like the most straightforward way to enforce uniformity across tags (
payjoin-{lang}-{version}+payjoin-{version}) despite some package managers not supporting the+syntax.Open to suggestions for better ways to structure the release tags. The current approach took inspiration from https://gitlab.com/ark-bitcoin/bark-ffi-bindings/-/blob/master/RELEASE.md?ref_type=heads#versioning-per-language