Skip to content

FISH-12192 bugfix: initialize WebContainer before HK2 class scanning so Rest APIs… #7902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lprimak wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −4
Open

FISH-12192 bugfix: initialize WebContainer before HK2 class scanning so Rest APIs… #7902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19978c1
bugfix: initialze WebContainer before HK2 class scanning so Rest APIs…
lprimak Jan 26, 2026
31c8009
Merge branch 'main' into fix-web-container
lprimak Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions nucleus/core/kernel/src/main/java/com/sun/enterprise/v3/server/ApplicationLifecycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import com.sun.enterprise.config.serverbeans.*;
import com.sun.enterprise.deploy.shared.ArchiveFactory;
import com.sun.enterprise.deploy.shared.FileArchive;
import com.sun.enterprise.loader.CachingReflectionUtil;
import com.sun.enterprise.util.LocalStringManagerImpl;
import com.sun.enterprise.util.io.FileUtils;
import fish.payara.enterprise.config.serverbeans.DeploymentGroup;
Expand Down Expand Up @@ -393,10 +394,16 @@ public void actOn(Logger logger) {
return null;
}

span.start(DeploymentTracing.AppStage.PREPARE, "ClassLoaderHierarchy");
ClassLoaderHierarchy clh = habitat.getService(ClassLoaderHierarchy.class);

span.start(DeploymentTracing.AppStage.CLASS_SCANNING);

Types types = null;
if (handler.requiresAnnotationScanning(context.getSource())) {
// web container needs to be loaded before deployable classes can be determined correctly
habitat.getService(CachingReflectionUtil
.getClass("com.sun.enterprise.web.WebContainer", clh.getCommonClassLoader()));
types = getDeployableTypes(context);
}

Expand All @@ -417,10 +424,6 @@ public void actOn(Logger logger) {
final Collection<? extends Sniffer> selectedSniffers = sniffers;
appState.ifPresent(s -> s.setSniffers(selectedSniffers));

span.start(DeploymentTracing.AppStage.PREPARE, "ClassLoaderHierarchy");

ClassLoaderHierarchy clh = habitat.getService(ClassLoaderHierarchy.class);

span.start(DeploymentTracing.AppStage.PREPARE, "ClassLoader");

context.createDeploymentClassLoader(clh, handler);
Expand Down