FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR#7032
Merged
Merged
Conversation
Contributor
Author
|
@Pandrex247 Do you think you can run the TCK against this PR? Thank you! |
lprimak
changed the title
Member
|
@lprimak I ran it through the CDI and EJB TCKs and all seems green 👍 |
Contributor
Author
|
Thanks, Fantastic! |
lprimak
commented
Oct 28, 2024
lprimak
force-pushed
the
cdi-ear-exception
branch
from
1c8a517 to
93071cf
Compare
Contributor
Author
|
I have found a few issues that I found with "real" applications. |
Contributor
Author
|
|
lprimak
force-pushed
the
cdi-ear-exception
branch
2 times, most recently
from
89ef769 to
4a79348
Compare
Contributor
Author
|
Im getting close. "Real" application runs. |
lprimak
force-pushed
the
cdi-ear-exception
branch
from
61c4079 to
2471951
Compare
Contributor
Author
|
Ready to go. Will do #6405 in a separate PR |
Contributor
Author
|
Now I gotta fix the conflict :) |
Contributor
Author
|
Once the tests passes I am going to squash the commits and un-draft the PR again |
lprimak
force-pushed
the
cdi-ear-exception
branch
from
766eb3e to
d2fbb5a
Compare
Contributor
Author
|
Ready to go again |
kalinchan
reviewed
Nov 30, 2024
lprimak
force-pushed
the
cdi-ear-exception
branch
from
734fc05 to
ad4885b
Compare
Pandrex247
changed the title
lprimak
force-pushed
the
cdi-ear-exception
branch
2 times, most recently
from
975cb97 to
a4f4f36
Compare
Contributor
Author
|
This one is the head of the backlog now |
Contributor
Author
|
Reproducer builds fine on Windows, as it looks like, but it won't run. As far as 500 error, I have no idea as I don't have windows. Do you have an exception at least? |
Contributor
|
These are the log server, but it is not related to your application: But a different error occurs when trying to undeploy: |
Contributor
Author
|
Yes, that doesn't look at all related. |
Contributor
@lprimak forget about the 1st issue regarding Windows 11, It was my local maven repo which was corrupted. Now please try to reproduce the Undeploy issue on your local, because this one seems to be related to your changes: |
Contributor
Author
|
I was able to reproduce the problem. It seems I forgot to re-test my sample app, just more sophisticated ones, |
lprimak
force-pushed
the
cdi-ear-exception
branch
from
9362adb to
5475ead
Compare
…I-enabled library JARs
- correctly copy BDA sets for each war in EAR
- Make WAR's CDI beans available in EAR-libs
- read web-fragment.xml from EAR-libs
- processing ear-lib manifest
- de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList
- made some structures final (cleanup)
- fixed ear and concurrent classloader leaks, including refactored reflection caching
lprimak
force-pushed
the
cdi-ear-exception
branch
from
1ce7a13 to
f414137
Compare
Contributor
Author
|
@luiseufrasio Fixed. Thank you |
luiseufrasio
approved these changes
Feb 10, 2025
luiseufrasio
left a comment
luiseufrasio
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Deploy and Undeploy are ok now. I also did the manual tests and they worked well.
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Feb 18, 2025
FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Mar 3, 2025
FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Mar 5, 2025
FISH-10049 bugfix: Split CDI bean deployment when multiple WARs exist in an EAR
This was referenced Mar 10, 2025
Pandrex247
added a commit
to Pandrex247/Payara
that referenced
this pull request
Mar 10, 2025
This reverts commit b236c3b.
lprimak
added a commit
to flowlogix/Payara
that referenced
this pull request
May 1, 2025
…I-enabled library JARs (payara#7032) - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - read web-fragment.xml from EAR-libs - processing ear-lib manifest - de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - made some structures final (cleanup) - fixed ear and concurrent classloader leaks, including refactored reflection caching enh: loading JARs from <domain_dir>/lib/warlibs if --properies warlibs=true is specified (payara#7097) bugfix: EAR deployment bugs found (payara#7212) - fixed current deployment context - made it a regular thread local, not queue - actually destroy deployment ClassLoader shareableTemp correctly - added fish.payara.ear-combined-cdi-deployment property to force combined EAR CDI deployment - Jax-JS Json-B injection retrives the correct BeanManager based on the actual type of the injection point desired
lprimak
added a commit
to flowlogix/Payara
that referenced
this pull request
May 5, 2025
…I-enabled library JARs (payara#7032) - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - read web-fragment.xml from EAR-libs - processing ear-lib manifest - de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - made some structures final (cleanup) - fixed ear and concurrent classloader leaks, including refactored reflection caching enh: loading JARs from <domain_dir>/lib/warlibs if --properies warlibs=true is specified (payara#7097) bugfix: EAR deployment bugs found (payara#7212) - fixed current deployment context - made it a regular thread local, not queue - actually destroy deployment ClassLoader shareableTemp correctly - added fish.payara.ear-combined-cdi-deployment property to force combined EAR CDI deployment - Jax-JS Json-B injection retrives the correct BeanManager based on the actual type of the injection point desired
lprimak
added a commit
to flowlogix/Payara
that referenced
this pull request
May 5, 2025
…I-enabled library JARs (payara#7032) - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - read web-fragment.xml from EAR-libs - processing ear-lib manifest - de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - made some structures final (cleanup) - fixed ear and concurrent classloader leaks, including refactored reflection caching enh: loading JARs from <domain_dir>/lib/warlibs if --properies warlibs=true is specified (payara#7097) bugfix: EAR deployment bugs found (payara#7212) - fixed current deployment context - made it a regular thread local, not queue - actually destroy deployment ClassLoader shareableTemp correctly - added fish.payara.ear-combined-cdi-deployment property to force combined EAR CDI deployment - Jax-JS Json-B injection retrives the correct BeanManager based on the actual type of the injection point desired
lprimak
added a commit
to flowlogix/Payara
that referenced
this pull request
May 5, 2025
…I-enabled library JARs (payara#7032) - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - read web-fragment.xml from EAR-libs - processing ear-lib manifest - de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - made some structures final (cleanup) - fixed ear and concurrent classloader leaks, including refactored reflection caching enh: loading JARs from <domain_dir>/lib/warlibs if --properies warlibs=true is specified (payara#7097) bugfix: EAR deployment bugs found (payara#7212) - fixed current deployment context - made it a regular thread local, not queue - actually destroy deployment ClassLoader shareableTemp correctly - added fish.payara.ear-combined-cdi-deployment property to force combined EAR CDI deployment - Jax-JS Json-B injection retrives the correct BeanManager based on the actual type of the injection point desired
lprimak
added a commit
to flowlogix/Payara
that referenced
this pull request
May 6, 2025
…I-enabled library JARs (payara#7032) - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - read web-fragment.xml from EAR-libs - processing ear-lib manifest - de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - made some structures final (cleanup) - fixed ear and concurrent classloader leaks, including refactored reflection caching enh: loading JARs from <domain_dir>/lib/warlibs if --properies warlibs=true is specified (payara#7097) bugfix: EAR deployment bugs found (payara#7212) - fixed current deployment context - made it a regular thread local, not queue - actually destroy deployment ClassLoader shareableTemp correctly - added fish.payara.ear-combined-cdi-deployment property to force combined EAR CDI deployment - Jax-JS Json-B injection retrives the correct BeanManager based on the actual type of the injection point desired
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugfix. BeanManager isn't properly constructed when multiple CDI WARs exist in an EAR.
Also allows EAR-libraries to be scanned for CDI annotations
fixes #7031
also fixes #7078
Appears specifically when multiple WARs use OmniFaces
Important Info
This is the head PR in the CDI-performance and modernization sequence.
PRs #7165 and #7097 depend on this PR
Testing
Tested with the failing reproducer
** Needs TCK run