Repository navigation
Fix Postgres query cells rendering as blanks - #25
Merged
Merged
Conversation
The query path still decodes every cell as String (empty on failure). This test pins the types that must render as readable values. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
based | 3df6cec | Commit Preview URL Branch Preview URL |
Oct 03 2026, 05:25 PM |
Share one decoder between execute_sql and the data viewer so ints, bools, timestamps, numeric, json, and uuid render as values, not blanks. Co-authored-by: Pavitra Golchha <hello@pavi2410.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Postgres query-grid cells for integers, bools, timestamps, numeric, json, and uuid came back empty. The query path decoded every cell as
Stringand turned a failed decode into"". The data viewer had its owntry_getchain that still missed date/time types, so those rendered as the null sentinel.Fix
One decoder in
based-postgres(decode_pg_cell/pg_cell_display):execute_sqland the data viewer both call itNULLNo new UI. No sqlx feature flags or extra type crates —
timeis already a workspace/sqlx dependency.Test
decode_pg_cell_shows_values_not_blanksfeeds binary fixtures for the types that used to go blank and asserts readable values.Out of scope
Timeouts, statement splitting, row caps, SSL, SQLite.