Map Throwable.getMessage() to Exception.Message (#165) - #174
Merged
Conversation
Java's `e.getMessage()` converted to `e.GetMessage()`, which does not compile against C#'s `Exception`. Route it through the existing `TryTransformMethodCall` property-replacement path, alongside `length` and `size`, so it becomes the `Message` property access. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #165.
Java's
e.getMessage()converted toe.GetMessage(), which doesn't compile against C#'sException.TypeHelper.TryTransformMethodCallalready had aReplaceMethodByPropertyhelper backinglength→Lengthandsize→Count— that's exactly the method-call-to-property-access handling the issue noted was needed, sogetMessage→Messageslots in there rather than into the name-onlyReplaceCommonMethodNamestable.The case is guarded on zero arguments, matching the surrounding cases, so an unrelated
obj.getMessage(i)still converts to a normal method call.Tests
ConvertExpressionTests(e.getMessage()→e.Message, and the arity-guard negative case).Resources/ExceptionGetMessage.javafixture wired intoFullIntegrationTests, so the generated C# is compiled and run: it throws anIllegalArgumentException, catches it, and asserts the printed message.Full suite passes at 363 tests.
Note
Java's
Throwablehas sibling accessors with the same problem (getLocalizedMessage(),getCause()). This PR stays scoped togetMessage()as the issue described; happy to follow up on the others.🤖 Generated with Claude Code