Repository navigation
Add a Buttondown newsletter signup to the website - #268
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a newsletter signup section to the getdux.app homepage, placed right after the hero. The form posts directly to Buttondown's embed-subscribe endpoint for the
getduxappnewsletter, needs no client-side JavaScript, and is styled entirely with the site's existing theme tokens (card,pill,btn-primary, and the shared focus-ring treatment). A Newsletter link was also added to the footer navigation, and the README gains a small shields.io badge pointing to the Buttondown subscribe page.It also adds two internal landing pages that match the rest of the site's look and tone:
/newsletter/thanks, shown after someone subscribes and reminding them to click the confirmation email before anything arrives, and/newsletter/confirmed, shown once the subscription is confirmed. Both are built on a small sharedNewsletterStatuscomponent so they cannot drift apart visually, are markednoindex, and are excluded from the sitemap since they only make sense as redirect targets.For the pages to be used, Buttondown's dashboard needs its redirect after subscribing and redirect after confirmation settings pointed at
https://getdux.app/newsletter/thanksandhttps://getdux.app/newsletter/confirmedrespectively. Until then, subscribers land on Buttondown's hosted pages and everything still works.