Report offending input in waveforms.py error messages - #1094
Merged
a-corni merged 1 commit intoAug 12, 2026
Conversation
Adds the failing input to the 7 validation errors in waveforms.py that previously stated only the rule. Existing message text is kept intact and the details appended, so the match= assertions in tests/test_waveforms.py continue to pass. Partially addresses pasqal-io#1057.
Contributor
Author
|
@a-corni ready for review whenever you have time — thanks for the guidance on the issue. |
a-corni
reviewed
Aug 11, 2026
a-corni
left a comment
a-corni
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @jaewonyun1234 for your work! It looks good to me, I just have one improvement to suggest.
a-corni
approved these changes
Aug 12, 2026
a-corni
left a comment
a-corni
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for the great work @jaewonyun1234!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the offending input to the error messages in
waveforms.pythatpreviously stated only the rule, following the pattern from #1093.
The existing message text is left intact and the new details appended, so
the
match=assertions intests/test_waveforms.pykeep passing withoutmodification.
BlackmanWaveform.from_max_valandKaiserWaveform.from_max_valshared anidentical message; both now report the class via
cls.__name__, so the twocan be told apart.
Partially addresses #1057.