Skip to content

Fixed pulse validation edge case #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-corni wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixed pulse validation edge case #1093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba5f0ee
Fixed pulse validation edge case
Janvee31 May 7, 2026
59ffae5
Tackle review comments
a-corni Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pulser-core/pulser/pulse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ def __init__(
)
if np.any(amplitude.samples.as_array(detach=True) < 0):
raise ValueError(
"All samples of an amplitude waveform must be "
"greater than or equal to zero."
"All samples of an amplitude waveform must be >= 0; "
f"found negative values in amplitude waveform: {amplitude}."
)
object.__setattr__(self, "amplitude", amplitude)
object.__setattr__(self, "detuning", detuning)
Expand Down
Loading