Refine the phase update moments in the samples - #1066
Draft
HGSilveri wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although these are inconsequential to the results, the current representation of the moment a phase jump occurs is not an accurate depiction of what happens on the hardware.
Currently, the phase jump moment is displayed as being "as late as possible" (i.e.
phase_jump_timebefore the beginning of the next pulse):In reality, the phase jumps actually occur "as early as possible" (i.e. as soon as the previous pulse is fully ramped down):
This PR introduces the necessary changes to go from Picture 1 to Picture 2.
I'm keeping this as a draft for now because it has downstream consequences in dependant packages. We should only merge once we have thoroughly checked them all.