Improve pulse waveform validation error messagesFixed pulse validation edge case - #1058
Closed
Janvee31 wants to merge 1 commit into
Closed
Improve pulse waveform validation error messagesFixed pulse validation edge case#1058Janvee31 wants to merge 1 commit into
Janvee31 wants to merge 1 commit into
Conversation
Collaborator
|
Hello @Janvee31 ! Thanks for your contribution ! |
Collaborator
|
Hello @Janvee31, |
a-corni
reviewed
May 20, 2026
| "All samples of an amplitude waveform must be " | ||
| "greater than or equal to zero." | ||
| ) | ||
| f"All samples of an amplitude waveform must be >= 0; " |
Collaborator
There was a problem hiding this comment.
flake8 is complaining because this f-string doesn't have any value to fill in. Delete the f to pass the tests.
| "greater than or equal to zero." | ||
| ) | ||
| f"All samples of an amplitude waveform must be >= 0; " | ||
| f"found invalid values in amplitude waveform: {amplitude}." |
Collaborator
There was a problem hiding this comment.
I find the suggestion of @HGSilveri better:
Suggested change
| f"found invalid values in amplitude waveform: {amplitude}." | |
| f"found negative values in amplitude waveform: {amplitude}." |
Collaborator
|
This tackles partially #1057 (only for pulse waveform). |
Collaborator
|
Hey @Janvee31, it's been a while since this PR has been idle. Are you planning on picking it back up soon? |
Collaborator
|
Closing this PR as completed by #1093 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved the validation error messages in
pulse.pyto make them clearer and more user-friendly.Testing
pytest tests/test_pulse.pypytest -qAll tests passed successfully.